Bug 1094057
| Summary: | Review Request: libes - Managing an entity system in C++ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre Marijon <pierre> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED INSUFFICIENT_DATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jwakely, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-13 09:32:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Pierre Marijon
2014-05-04 19:18:28 UTC
*** Bug 1094056 has been marked as a duplicate of this bug. *** It's my first package and i need a sponsor (yes i read too fast the wiki). * Upstream project page : https://github.com/jube/libes * Koji result http://koji.fedoraproject.org/koji/taskinfo?taskID=6812591 * https://fedoraproject.org/wiki/Package_Review_Process#Contributor * https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group * Please enter your full name in the bugzilla account preferences. * Consider running "fedora-review -b 1094057" to point that tool at this ticket for many helpful checks. > %package doc > Summary: Documentation files for %{name} > Requires: %{name}%{?_isa} = %{version}-%{release} Is that -doc subpackage really arch-specific? It contains HTML documentation. "BuildArch: noarch" sounds plausible. For reading the HTML documentation one does not need to install the base library package. Please don't add such a dependency to _independent_ -doc packages. If the documentation can only be displayed with a program in the base package, that would be an example of a case when to add such a dep. In case you added the dep only for the license and directories included in the base package, consider duplicating the license file and dirs in the -doc package instead. > %files > %{_libdir}/*.so > %dir %{_defaultdocdir}/es > %doc %{_defaultdocdir}/es/COPYING Uh, that's odd. If the package is named "libes", it ought to store doc files in a directory named "libes" not "es". Btw, in spec files you can use %_docdir just fine, and files below /usr/share/doc are marked as %doc implicitly (see "rpm -E %__docdir_path"). I follow your recommendation Spec URL: http://static.pierre.marijon.fr/rpm/libes/libes.spec.0.2 SRPM URL: http://static.pierre.marijon.fr/rpm/libes/libes-0.5.2-0.2.fc20.src.rpm fedora-review for 0.2 : http://static.pierre.marijon.fr/rpm/libes/review.txt.0.2 koji link : http://koji.fedoraproject.org/koji/taskinfo?taskID=6813416 > http://static.pierre.marijon.fr/rpm/libes/review.txt.0.2
The tool has found an issue with your package. ;-)
Ok upstream add patch for documentation installation. Spec URL: http://static.pierre.marijon.fr/rpm/libes/libes.spec SRPM URL: http://static.pierre.marijon.fr/rpm/libes/libes-0.5.3-0.1.fc20.src.rpm local fedora-review (i check all is ok) : http://static.pierre.marijon.fr/rpm/libes/review.txt.0.5.3-0.1 koji link : http://koji.fedoraproject.org/koji/taskinfo?taskID=6826185 Summary: Library for managing an entity system written in c++ C++ should be capitalized. I would expect Entity System to be capitalized too if it's a technical term %description If you do not know what an entity system is, you should read the following http://entity-systems.wikidot.com This doesn't look like a very good description for the package! The link describes it as "Component/Entity System" which is a better (less generic) name. Wikipedia uses Entity-component system: https://en.wikipedia.org/wiki/Entity_component_system 404 not found and several years without activity |