Bug 1094329 (kf5-kcoreaddons)
| Summary: | Review Request: kf5-kcoreaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtCore | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, jgrulich, kevin, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-19 09:05:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1086148 | ||
|
Description
Daniel Vrátil
2014-05-05 13:12:49 UTC
Build fine on Rawhide. License should be GPLv2+ and LGPLv2+. Rpmlint shows errors: kf5-kcoreaddons.x86_64: W: shared-lib-calls-exit /usr/lib64/libKF5CoreAddons.so.4.99.0 exit.5 Not sure whether this one is false positive. kf5-kcoreaddons.x86_64: E: incorrect-locale-subdir /usr/share/locale/x-test/LC_MESSAGES/kcoreaddons5_qt.qm This should be false positive. Fixed license in our git. exit(EXIT_SUCCESS) is indeed called from KCoreAddons, specifically from KAboutData class. KAboutData invokes exit() when application is started with --author or --license argument. At this point, calling exit() is expected behavior as the application prints author or license and terminates (also, it's the same as in kdelibs4). Ok, can be approved. New Package SCM Request ======================= Package Name: kf5-kcoreaddons Short Description: KDE Frameworks 5 Tier 1 addon with various classes on top of QtCore Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC: Git done (by process-git-requests). Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Package Change Request ======================= Package Name: kf5-kcoreaddons New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Git done (by process-git-requests). |