Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kcoreaddons.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kcoreaddons-4.99.0-1.fc20.src.rpm Description: KCoreAddons provides classes built on top of QtCore to perform various tasks such as manipulating mime types, autosaving files, creating backup files, generating random sequences, performing text manipulations such as macro replacement, accessing user information and many more. Fedora Account System Username: dvratil
Build fine on Rawhide. License should be GPLv2+ and LGPLv2+. Rpmlint shows errors: kf5-kcoreaddons.x86_64: W: shared-lib-calls-exit /usr/lib64/libKF5CoreAddons.so.4.99.0 exit.5 Not sure whether this one is false positive. kf5-kcoreaddons.x86_64: E: incorrect-locale-subdir /usr/share/locale/x-test/LC_MESSAGES/kcoreaddons5_qt.qm This should be false positive.
Fixed license in our git. exit(EXIT_SUCCESS) is indeed called from KCoreAddons, specifically from KAboutData class. KAboutData invokes exit() when application is started with --author or --license argument. At this point, calling exit() is expected behavior as the application prints author or license and terminates (also, it's the same as in kdelibs4).
Ok, can be approved.
New Package SCM Request ======================= Package Name: kf5-kcoreaddons Short Description: KDE Frameworks 5 Tier 1 addon with various classes on top of QtCore Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than
Package Change Request ======================= Package Name: kf5-kcoreaddons New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than