Bug 1094331 (kf5-kdbusaddons)
| Summary: | Review Request: kf5-kdbusaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtDBus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, jgrulich, kevin, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-05-19 09:06:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1086148 | ||
|
Description
Daniel Vrátil
2014-05-05 13:14:16 UTC
1) License should be LGPLv2+ And something from rpmlint: 2) W: shared-lib-calls-exit /usr/lib64/libKF5DBusAddons.so.4.99.0 exit.5 - this should be investigated whether it's not false positive warning. 3) W: incoherent-version-in-changelog 4.99.0 ['4.99.0-1.fc21', '4.99.0-1'] Fixed license and changelog versioning in our git. KDbusAddons indeed calls exit(), specifically in KDBusService class, when the service fails to connect to the bus during initialization. However exit() is invoked only when user does not specify KDBusService::NoExitOnFailure. Ok, can be approved. New Package SCM Request ======================= Package Name: kf5-kdbusaddons Short Description: KDE Frameworks Tier 1 addon with various classes on top of QtDBus Owners: dvratil jgrulich kkofler rdieter ltinkl Branches: InitialCC: Git done (by process-git-requests). Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Package Change Request ======================= Package Name: kf5-kdbusaddons New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Git done (by process-git-requests). |