Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdbusaddons.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdbusaddons-4.99.0-1.fc20.src.rpm Description: KDBusAddons provides convenience classes on top of QtDBus, as well as an API to create KDED modules. Fedora Account System Username: dvratil
1) License should be LGPLv2+ And something from rpmlint: 2) W: shared-lib-calls-exit /usr/lib64/libKF5DBusAddons.so.4.99.0 exit.5 - this should be investigated whether it's not false positive warning. 3) W: incoherent-version-in-changelog 4.99.0 ['4.99.0-1.fc21', '4.99.0-1']
Fixed license and changelog versioning in our git. KDbusAddons indeed calls exit(), specifically in KDBusService class, when the service fails to connect to the bus during initialization. However exit() is invoked only when user does not specify KDBusService::NoExitOnFailure.
Ok, can be approved.
New Package SCM Request ======================= Package Name: kf5-kdbusaddons Short Description: KDE Frameworks Tier 1 addon with various classes on top of QtDBus Owners: dvratil jgrulich kkofler rdieter ltinkl Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than
Package Change Request ======================= Package Name: kf5-kdbusaddons New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than