Bug 1094344 (kf5-kjs)

Summary:	Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
Product:	[Fedora] Fedora	Reporter:	Daniel Vrátil <dvratil>
Component:	Package Review	Assignee:	Jan Grulich <jgrulich>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jeischma, jgrulich, kevin, package-review
Target Milestone:	---	Flags:	jgrulich: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-27 15:58:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997, 1086148

Description Daniel Vrátil 2014-05-05 13:30:19 UTC

Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-1.fc20.src.rpm
Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret.
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2014-05-27 08:16:34 UTC

1) License should be LGPLv2+ and BSD
2) Wrong source url, kjs is in http://download.kde.org/unstable/frameworks/4.99.0/portingAids/
3) Shouldn't be create_hash_table script executable? Rpmlint says:
E: non-executable-script /usr/share/kf5/kjs/create_hash_table 0644L /usr/bin/perl

Comment 2 Daniel Vrátil 2014-05-27 09:08:39 UTC

Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-3.fc20.src.rpm

- Fixed license
- Fixed changelog
- Fixed source URL
- chmod +x create_hash_table

Comment 3 Jan Grulich 2014-05-27 09:14:11 UTC

Approved.

Comment 4 Daniel Vrátil 2014-05-27 09:15:47 UTC

New Package SCM Request
=======================
Package Name: kf5-kjs
Short Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2014-05-27 13:06:50 UTC

Git done (by process-git-requests).

Comment 6 Daniel Vrátil 2014-09-25 08:51:48 UTC

Package Change Request
=======================
Package Name: kf5-kjs
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than

Comment 7 Gwyn Ciesla 2014-09-25 12:27:06 UTC

Git done (by process-git-requests).