Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-1.fc20.src.rpm Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret. Fedora Account System Username: dvratil
1) License should be LGPLv2+ and BSD 2) Wrong source url, kjs is in http://download.kde.org/unstable/frameworks/4.99.0/portingAids/ 3) Shouldn't be create_hash_table script executable? Rpmlint says: E: non-executable-script /usr/share/kf5/kjs/create_hash_table 0644L /usr/bin/perl
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-3.fc20.src.rpm - Fixed license - Fixed changelog - Fixed source URL - chmod +x create_hash_table
Approved.
New Package SCM Request ======================= Package Name: kf5-kjs Short Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: kf5-kjs New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than