Bug 1094344 (kf5-kjs) - Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
Summary: Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with Java...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kjs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-05-05 13:30 UTC by Daniel Vrátil
Modified: 2015-11-02 01:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-27 15:58:32 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2014-05-05 13:30:19 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-1.fc20.src.rpm
Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret.
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2014-05-27 08:16:34 UTC
1) License should be LGPLv2+ and BSD
2) Wrong source url, kjs is in http://download.kde.org/unstable/frameworks/4.99.0/portingAids/
3) Shouldn't be create_hash_table script executable? Rpmlint says:
E: non-executable-script /usr/share/kf5/kjs/create_hash_table 0644L /usr/bin/perl

Comment 2 Daniel Vrátil 2014-05-27 09:08:39 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-3.fc20.src.rpm

- Fixed license
- Fixed changelog
- Fixed source URL
- chmod +x create_hash_table

Comment 3 Jan Grulich 2014-05-27 09:14:11 UTC
Approved.

Comment 4 Daniel Vrátil 2014-05-27 09:15:47 UTC
New Package SCM Request
=======================
Package Name: kf5-kjs
Short Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2014-05-27 13:06:50 UTC
Git done (by process-git-requests).

Comment 6 Daniel Vrátil 2014-09-25 08:51:48 UTC
Package Change Request
=======================
Package Name: kf5-kjs
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than

Comment 7 Gwyn Ciesla 2014-09-25 12:27:06 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.