Bug 1094360

Summary: Disable strict-aliasing optimization for rsh
Product: Red Hat Enterprise Linux 6 Reporter: Michal Sekletar <msekleta>
Component: rshAssignee: Michal Sekletar <msekleta>
Status: CLOSED ERRATA QA Contact: Tomas Dolezal <todoleza>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.6CC: jherrman, ovasik, psklenar, todoleza
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rsh-0.17-64.el6 Doc Type: Bug Fix
Doc Text:
Prior to this update, the rsh application was optimized through strict aliasing rules, even though it is not a performance-sensitive application. As a consequence, the GNU compiler collection (GCC) generated warning messages about breaking the strict-aliasing rules, despite correct functionality being the priority for rsh. With this update, strict aliasing has been disabled for rsh. Therefore, GCC now ignores the strict aliasing rules and no longer interrupts rsh processes with warning messages. However, this may also lead to a slight decrease in performance.
 Story Points: ---
Clone Of:
: 1095304 1095306 (view as bug list) Environment:
Last Closed: 2014-06-26 07:57:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1095306    

Description Michal Sekletar 2014-05-05 14:03:25 UTC 
Description of problem:
Warnings about breaking strict aliasing rules in build.log

Version-Release number of selected component (if applicable):
rsh-0.17-60

How reproducible:
always

Steps to Reproduce:
1. Rebuild for RHEL-6.6

Actual results:
rshd.c:453: warning: dereferencing pointer 'second_connect.62' does break strict-aliasing rules

Expected results:
No such warnings

Additional info:
I guess toolchain, i.e. gcc, changed somehow. Let's play this safe and disable optimization. spec only change, add -fno-strict-aliasing to RPM_OPT_FLAGS.
Comment 4 Tomas Dolezal 2014-06-19 09:10:37 UTC 
VERIFIED rsh-0.17-64.el6.src.rpm @x86_64
Comment 6 errata-xmlrpc 2014-06-26 07:57:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0795.html