Bug 1094759

Summary: taglib test suit is not run during build
Product: [Fedora] Fedora Reporter: Jakub Čajka <jcajka>
Component: taglibAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 20CC: drizt72, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-06 12:45:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch enables tests during build none

Description Jakub Čajka 2014-05-06 12:34:48 UTC 
Created attachment 892851 [details]
Patch enables tests during build

Description of problem:
Build-in unit test are not run during package build %check phase.

How reproducible:
always

Steps to Reproduce:
Build package from srpm using koji or localy

Actual results:
Tests are not run during package build.

Expected results:
Tests are run during package build.

Additional info:
Tests should be run in the %check phase according to packaging guidelines. In attachment is tests enabling patch for f20 spec file.

Tests pass successfully in a koji scratch build(http://koji.fedoraproject.org/koji/taskinfo?taskID=6818034) for f20 primary architectures and build time isn't changed significantly(few seconds). 

Do you have any reasons to not enable them?  If not please enable them in all Fedora versions.

Thanks 

Jakub
Comment 1 Rex Dieter 2014-05-06 12:38:12 UTC 
I don't recall why they're not enabled by default, but the easier way to do it, is to toggle
%bconf_without tests

at the top of taglib.spec

I'll do just that shortly.
Comment 2 Rex Dieter 2014-05-06 12:38:39 UTC 
(minus my typo)
Comment 3 Rex Dieter 2014-05-06 12:45:15 UTC 
http://pkgs.fedoraproject.org/cgit/taglib.git/commit/?id=659267308327772a7878ed37fcd9d439aed11c05

The change will filter down to stable branches when/if we do any future bugfix releases (I don't see any need to issue any updates just for this).