Created attachment 892851 [details] Patch enables tests during build Description of problem: Build-in unit test are not run during package build %check phase. How reproducible: always Steps to Reproduce: Build package from srpm using koji or localy Actual results: Tests are not run during package build. Expected results: Tests are run during package build. Additional info: Tests should be run in the %check phase according to packaging guidelines. In attachment is tests enabling patch for f20 spec file. Tests pass successfully in a koji scratch build(http://koji.fedoraproject.org/koji/taskinfo?taskID=6818034) for f20 primary architectures and build time isn't changed significantly(few seconds). Do you have any reasons to not enable them? If not please enable them in all Fedora versions. Thanks Jakub
I don't recall why they're not enabled by default, but the easier way to do it, is to toggle %bconf_without tests at the top of taglib.spec I'll do just that shortly.
(minus my typo)
http://pkgs.fedoraproject.org/cgit/taglib.git/commit/?id=659267308327772a7878ed37fcd9d439aed11c05 The change will filter down to stable branches when/if we do any future bugfix releases (I don't see any need to issue any updates just for this).