Bug 1095026

Summary:	Workflow commands should prefer --machine and ignore any other host selection criteria when both are specified
Product:	[Retired] Beaker	Reporter:	Amit Saha <asaha>
Component:	command line	Assignee:	Amit Saha <asaha>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	develop	CC:	aigao, asaha, dcallagh, ebaak, rmancy, xma
Target Milestone:	0.17
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-10 23:27:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amit Saha 2014-05-07 01:49:43 UTC

Description of problem:

As noted in https://bugzilla.redhat.com/show_bug.cgi?id=1093224#c5 , bkr machine-test (and other workflow commands) have a --machine and a --hostrequire switch. Now, if you specify both these, the job gets the following in <hostRequires> (for example):

<hostRequires>
<hostlabcontroller op="=" value="testlc.labcontroller"/>
<hostname op="=" value="test.system"/>
</hostRequires>

This doesn't make a lot of sense, and we should just use the hostname specified by --machine and ignore the --hostrequire.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:

The job XML only has :

<hostRequires>
<hostname op="=" value="test.system"/>
</hostRequires>

Additional info:

Comment 1 Amit Saha 2014-05-07 01:55:22 UTC

http://gerrit.beaker-project.org/#/c/3064/

Comment 6 Dan Callaghan 2014-06-10 23:27:54 UTC

Beaker 0.17.0 has been released.

Comment 7 Dan Callaghan 2017-05-17 02:50:05 UTC

Note that bug 1234323 came up with a valid case where --machine and --systype are both needed (contrary to the assumptions we made in this bug) so we will remove this code for ignoring the extra filter options.