Bug 1095026 - Workflow commands should prefer --machine and ignore any other host selection criteria when both are specified
Summary: Workflow commands should prefer --machine and ignore any other host selection...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: command line
Version: develop
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 0.17
Assignee: Amit Saha
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-07 01:49 UTC by Amit Saha
Modified: 2018-02-06 00:41 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-10 23:27:54 UTC
Embargoed:


Attachments (Terms of Use)

Description Amit Saha 2014-05-07 01:49:43 UTC
Description of problem:

As noted in https://bugzilla.redhat.com/show_bug.cgi?id=1093224#c5 , bkr machine-test (and other workflow commands) have a --machine and a --hostrequire switch. Now, if you specify both these, the job gets the following in <hostRequires> (for example):

<hostRequires>
<hostlabcontroller op="=" value="testlc.labcontroller"/>
<hostname op="=" value="test.system"/>
</hostRequires>

This doesn't make a lot of sense, and we should just use the hostname specified by --machine and ignore the --hostrequire.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:

The job XML only has :

<hostRequires>
<hostname op="=" value="test.system"/>
</hostRequires>

Additional info:

Comment 1 Amit Saha 2014-05-07 01:55:22 UTC
http://gerrit.beaker-project.org/#/c/3064/

Comment 6 Dan Callaghan 2014-06-10 23:27:54 UTC
Beaker 0.17.0 has been released.

Comment 7 Dan Callaghan 2017-05-17 02:50:05 UTC
Note that bug 1234323 came up with a valid case where --machine and --systype are both needed (contrary to the assumptions we made in this bug) so we will remove this code for ignoring the extra filter options.


Note You need to log in before you can comment on or make changes to this bug.