Bug 1096013
| Summary: | jboss-dmr: migrate to maven-processor-plugin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Srb <msrb> | ||||
| Component: | jboss-dmr | Assignee: | gil cattaneo <puntogil> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | mgoldman, msrb, puntogil | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-09-12 12:30:18 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1096007 | ||||||
| Bug Blocks: | 1096012, 1106864, 1181081 | ||||||
| Attachments: |
|
||||||
|
Description
Michal Srb
2014-05-09 05:26:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 Michal, any update on this? Created attachment 1005076 [details]
WIP patch
Michal, you could reuse the attached patch to make it work. In the current state of this patch the build throws:
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ jboss-dmr ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 23 source files to /builddir/build/BUILD/jboss-dmr-1.2.0.Final/target/classes
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Skipping JBoss Dynamic Model Representation
[INFO] This project has been banned from the build due to previous failures.
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.715 s
[INFO] Finished at: 2015-03-22T19:25:14+01:00
[INFO] Final Memory: 21M/185M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project jboss-dmr: Fatal error compiling: java.lang.IllegalArgumentException: The generated class cannot be a nested class. -> [Help 1]
DEBUG: Child return code was: 1
INFO: EXCEPTION: Command failed. See logs for output.
(In reply to Marek Goldmann from comment #2) > Michal, any update on this? Hi Marek, This turned out to be much more trickier than I initially thought. And I am not sure whether it makes sense to spend more time on it. Given the fact that cookcc upstream is pretty much inactive [1], and jboss-dmr upstream still building with JDK < 8 (as they apparently haven't hit the issue yet), I would say that using pre-generated sources could be a good trade-off for Fedora's jboss-dmr package. What do you think? [1]: https://code.google.com/p/cookcc/issues/detail?id=21 The package now builds with JDK8, but proper fix is still missing. This bug should probably stay open, but I am moving it back to NEW, since I don't plan to work on it anytime soon. latest cookcc (0.4) should work with Java8. available @ https://github.com/coconut2015/cookcc Is available a patch for remove cookcc and add Java8 support @ https://github.com/jbossas/jboss-dmr/pull/20 is available a pre-release which dont use anymore cookcc referencies https://github.com/jbossas/jboss-dmr/pull/20 Next Wildfly release should use jboss-drm-1.4.0.Beta1 Close this bug |