Bug 1096206
| Summary: | Review Request: python-click - A simple wrapper around optparse | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Kuska <rkuska> |
| Component: | Package Review | Assignee: | Matej Stuchlik <mstuchli> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jberan, mail, mstuchli, package-review |
| Target Milestone: | --- | Flags: | mstuchli:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-click-2.0-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-21 02:55:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert Kuska
2014-05-09 12:35:32 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6831394 I'll take this. I have updated the source. Spec URL: http://rkuska.fedorapeople.org/pkgs/python-click.spec SRPM URL: http://rkuska.fedorapeople.org/pkgs/python-click-0.7-1.fc20.src.rpm koji --scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6840819 We've discussed this in person and rkuska has made the following changes:
1) use
LANG=en_GB.utf8 LC_ALL=en_GB.utf8 (...) py.test (...)
instead of exporting all the variables with
export LANG=en_GB.utf8
(...)
2) remove
find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|'
since 'setup.py build' already rewrites shebang lines to start whichever interpreter path was used to invoke it
There was also an incorrect Source URL, which is now fixed. All in all, it looks good now, APPROVED. New Package SCM Request ======================= Package Name: python-click Short Description: A simple wrapper around optparse Upstream URL: https://github.com/mitsuhiko/click Owners: rkuska Branches: f20 InitialCC: Git done (by process-git-requests). python-click-1.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-click-1.1-2.fc20 python-click-1.1-2.fc20 has been pushed to the Fedora 20 testing repository. python-click-1.1-3.fc20 has been pushed to the Fedora 20 testing repository. Package Change Request ====================== Package Name: python-click New Branches: el6 epel7 Owners: rkuska bochecha InitialCC: python-click is a dependency of the upcoming Bodhi 2 python-click-2.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-click-2.0-1.fc20 Git done (by process-git-requests). python-click-2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-click-2.0-2.el6 python-click-2.0-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. python-click-2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. *** Bug 1148940 has been marked as a duplicate of this bug. *** |