Bug 1096206 - Review Request: python-click - A simple wrapper around optparse
Summary: Review Request: python-click - A simple wrapper around optparse
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matej Stuchlik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1148940 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-09 12:35 UTC by Robert Kuska
Modified: 2016-02-01 02:15 UTC (History)
4 users (show)

Fixed In Version: python-click-2.0-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-21 02:55:24 UTC
Type: ---
Embargoed:
mstuchli: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Robert Kuska 2014-05-09 12:35:32 UTC
Spec URL: http://rkuska.fedorapeople.org/pkgs/python-click.spec
SRPM URL: http://rkuska.fedorapeople.org/pkgs/python-click-0.6-1.fc20.src.rpm
Description: click is a Python package for creating beautiful command line
interfaces in a composable way with as little amount of code as necessary.
It's the "Command Line Interface Creation Kit".  It's highly configurable but
comes with good defaults out of the box.
Fedora Account System Username: rkuska

Comment 1 Robert Kuska 2014-05-09 12:36:04 UTC
Koji scratch build: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=6831394

Comment 2 Matej Stuchlik 2014-05-09 13:44:26 UTC
I'll take this.

Comment 4 Matej Stuchlik 2014-05-12 08:34:19 UTC
We've discussed this in person and rkuska has made the following changes:

1) use

LANG=en_GB.utf8 LC_ALL=en_GB.utf8 (...) py.test (...)

instead of exporting all the variables with

export LANG=en_GB.utf8
(...)

2) remove

find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|'

since 'setup.py build' already rewrites shebang lines to start whichever interpreter path was used to invoke it

Comment 5 Matej Stuchlik 2014-05-12 09:22:02 UTC
There was also an incorrect Source URL, which is now fixed.

All in all, it looks good now, APPROVED.

Comment 6 Robert Kuska 2014-05-27 07:35:20 UTC
New Package SCM Request
=======================
Package Name: python-click
Short Description: A simple wrapper around optparse
Upstream URL: https://github.com/mitsuhiko/click
Owners: rkuska 
Branches: f20
InitialCC:

Comment 7 Gwyn Ciesla 2014-05-27 13:13:02 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-05-29 18:38:14 UTC
python-click-1.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-click-1.1-2.fc20

Comment 9 Fedora Update System 2014-05-30 23:52:22 UTC
python-click-1.1-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 10 Fedora Update System 2014-06-10 02:58:53 UTC
python-click-1.1-3.fc20 has been pushed to the Fedora 20 testing repository.

Comment 11 Robert Kuska 2014-06-12 08:32:17 UTC
Package Change Request
======================
Package Name: python-click
New Branches: el6 epel7
Owners: rkuska bochecha
InitialCC:

python-click is a dependency of the upcoming Bodhi 2

Comment 12 Fedora Update System 2014-06-12 09:01:05 UTC
python-click-2.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-click-2.0-1.fc20

Comment 13 Gwyn Ciesla 2014-06-12 12:06:29 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2014-06-12 13:51:56 UTC
python-click-2.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-click-2.0-2.el6

Comment 15 Fedora Update System 2014-06-21 02:55:24 UTC
python-click-2.0-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2014-07-03 17:56:17 UTC
python-click-2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 17 Fabian Affolter 2014-10-02 17:27:12 UTC
*** Bug 1148940 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.