Bug 1096560

(In reply to Jun Li from comment #0)
> Description of problem:
> fail to assign correct order for the boot device in seabios as we specified
> the bootindex in qemu-kvm cli(under the same virtio-scsi-pci).
> This issue is different from bz923030(this bz is under different
> virtio-scsi-pci).
> 
> Version-Release number of selected component (if applicable):
> qemu-kvm-1.5.3-60.el7_0.2.x86_64
> seabios-bin-1.7.2.2-12.el7.x86_64
> 3.10.0-123.el7.x86_64
> 
> How reproducible:
> 100%
> 
> Steps to Reproduce:
> 1.boot guests using following cli:
> /usr/libexec/qemu-kvm -m 2G \
> -device virtio-scsi-pci,id=scsi0 \
> -drive
> file=/home/juli/win2012r2-64.qcow2-copy-from-auto,if=none,id=disk1,
> format=qcow2 \
> -device scsi-hd,drive=disk1,id=sys-disk1,scsi-id=100,lun=0,bootindex=0 \
> -boot menu=on -monitor stdio -vnc :2 \
> -drive
> file=/dev/disk/by-path/ip-10.66.9.10:3260-iscsi-iqn.2013-11.com.example:
> storage.disk1.juli.xyz-lun-2,if=none,id=disk2 \
> -device scsi-hd,drive=disk2,id=sys-disk2,scsi-id=0,lun=0,bootindex=3 -S
> 2.check the boot order in seabios.
> Press F12 for boot menu.
> 3.
> 
> Actual results:
> sys-disk2 is the first disk and sys-disk1 is the second disk when press F12.
> Such as:
> 1. virtio-scsi Drive QEMU QEMU HARDDISK 1.5.
> 2. virtio-scsi Drive QEMU QEMU HARDDISK 1.5.
> ...
> 
> Expected results:
> the order of the boot device in seabios should the same to we specified the
> bootindex in qemu-kvm command line.
> 
> Additional info:
You should specify the scsi-id and lun value for your system disk smaller than your data disk if you want to boot from the bootinde=0 disk, as the scsi-id and lun value has specify meaning for virtio-scsi here. I think this should not a bug.
e.g.: scsi-id=0,lun=0 for your system disk, scsi-id=1,lun=0 for your data disk.
The seabios can just detest the lun=0 for disk currently.

Best Regards,
sluo

Sibiao and Jun,
I am impressed!
Are you going to close this bug?

(In reply to Ronen Hod from comment #6)
> Sibiao and Jun,
> I am impressed!
> Are you going to close this bug?

Could you help make sure it, as comment #2 and comment #5 just my opinion. Thanks in advance.

Best Regards,
sluo

The reason why both virtio-scsi disks come first, is that drives with a bootindex always come before drives without a bootindex.  Since you had no drive with indexes 1 and 2, the two SCSI disks were placed first.

(In reply to Paolo Bonzini from comment #8)
> The reason why both virtio-scsi disks come first, is that drives with a
> bootindex always come before drives without a bootindex.  Since you had no
> drive with indexes 1 and 2, the two SCSI disks were placed first.

Hi Paolo,

  In comment #0, I just want to say:

-device scsi-hd,drive=disk1,id=sys-disk1,scsi-id=100,lun=0,bootindex=0 \
...
-device scsi-hd,drive=disk2,id=sys-disk2,scsi-id=0,lun=0,bootindex=3

------
  As above show, sys-disk1 with bootindex=0, sys-disk2 with bootindex=3. So we should see sys-disk1 before sys-disk2 when Press F12. But actually, we will see sys-disk2 before sys-disk1.

  Why hit above issue? I just find "scsi-id" causing this issue. When set scsi-id of sys-disk1 (with 100) larger than scsi-id of sys-disk2(with 0), bootindex will not effect. 

  Could you give some explanation? If you think this is not a bug, please close it. Thx.


Best Regards,
Jun Li

(In reply to Paolo Bonzini from comment #8)
> The reason why both virtio-scsi disks come first, is that drives with a
> bootindex always come before drives without a bootindex.  Since you had no
> drive with indexes 1 and 2, the two SCSI disks were placed first.

Hi Paolo,

  I think you have misunderstand my original meaning(comment #0 and comment #9), so I want to reopen this bz. When you have time, please help me to double-check this issue. Thank you very much.

   
Best regards,
Jun Li

Moving to Ademar, as this is mostly related to storage.

I know nothing about the interplay of SeaBIOS, virtio-scsi and
bootindex.  That's okay, I can figure it out.  But before I spend time
on that: Paolo, do you have anything to reply to comment#10?

Laszlo helped me understand this stuff better, thanks much!

Jun Li, I think you're right, this is a bug.  qemu-kvm formats the
SCSI ID in hex when building the Open Firmware device path.  SeaBIOS
formats in decimal.  Bootorder list entries with a SCSI ID > 9 aren't
found by SeaBIOS (lucky case), or attributed to the wrong device
(unlucky case).

Working on an upstream fix.

Please try my scratch brew of SeaBIOS[*], and let me know whether it
fixes the bug for you.

Additionally, please try to reproduce the bug under RHEL-6.  I suspect
that's broken, too.  If it is, clone the bug and assign it straight to
me.

[*] http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7838459

(In reply to Markus Armbruster from comment #16)
> Please try my scratch brew of SeaBIOS[*], and let me know whether it
> fixes the bug for you.
> 
> Additionally, please try to reproduce the bug under RHEL-6.  I suspect
> that's broken, too.  If it is, clone the bug and assign it straight to
> me.
> 
> [*] http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7838459

Retest with http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7838459.

Version of components:
# rpm -qa|grep seabios && rpm -qa|grep qemu-kvm-rhev
seabios-1.7.2.2-12.el7_0.test.x86_64
seabios-bin-1.7.2.2-12.el7_0.test.x86_64
qemu-kvm-rhev-1.5.3-60.el7ev.x86_64
qemu-kvm-rhev-debuginfo-1.5.3-60.el7ev.x86_64

Steps as comment #0:
1.boot guests using following cli:
/usr/libexec/qemu-kvm -m 2G \
-device virtio-scsi-pci,id=scsi0 \
-drive file=/mnt/windows_img/win2012-64-virtio.qcow2,if=none,id=disk1,format=qcow2,snapshot=on \
-device scsi-hd,drive=disk1,id=sys-disk1,scsi-id=100,lun=0,bootindex=0 \
-boot menu=on -monitor stdio -vnc :2 \
-drive file=/mnt/linux_img/RHEL-Server-7.0-64.qcow2,if=none,id=disk2,snapshot=on \
-device scsi-hd,drive=disk2,id=sys-disk2,scsi-id=0,lun=0,bootindex=3 -S
2.check the boot order in seabios.
Press F12 for boot menu.
3.

Actual results:
sys-disk1 is the first disk and sys-disk2 is the second disk when press F12.
Such as:
1. virtio-scsi Drive QEMU QEMU HARDDISK 1.5.
2. virtio-scsi Drive QEMU QEMU HARDDISK 1.5.
...

Above test result is our expired.

Hi Markus,

  Also test this issue on rhel6, it has the same issue, too. I will clone a bz on rhel 6. Thx.

Best Regards,
Jun Li

Thanks, Jun Li!

Reproduce this bug as follow version:
Host:
# uname -r
3.10.0-191.el7.x86_64
# rpm -q qemu-kvm-rhev
qemu-kvm-rhev-2.1.2-6.el7.x86_64
# rpm -q seabios
seabios-1.7.5-4.el7.x86_64


Steps:
1.Boot guest with
..-drive file=/home/RHEL-Server-7.0-64-virtio.qcow2,if=none,id=disk1,format=qcow2 -device scsi-hd,drive=disk1,id=sys-disk1,scsi-id=100,lun=0,bootindex=0 -boot menu=on -monitor stdio -vnc :2 -drive file=/home/win2012-64-virtio.qcow2,if=none,id=disk2 -device scsi-hd,drive=disk2,id=sys-disk2,scsi-id=0,lun=0,bootindex=3..


Results: guest boot up from the "bootindex=3" imag.

Verify this bug as follow version:

# uname -r
3.10.0-191.el7.x86_64
# rpm -q qemu-kvm-rhev
qemu-kvm-rhev-2.1.2-6.el7.x86_64
# rpm -q seabios
seabios-1.7.5-5.el7.x86_64

Steps as same as reproduce

Resutls:

Guest boot up from "bootindex=0" imag, work well


Addtional info: Tried boot guest with other values of "scsi-id" ,work well
..-device scsi-hd,drive=disk1,id=sys-disk1,scsi-id=101,lun=0,bootindex=0 ...-device scsi-hd,drive=disk2,id=sys-disk2,scsi-id=002,lun=0,bootindex=3


According to above test ,this bug has been fixed.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0345.html