Bug 1097714

Summary: Review Request: golang-github-spacemonkeygo-spacelog - Designed to help you build a flexible logging system
Product: [Fedora] Fedora Reporter: Robert Kuska <rkuska>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-05 00:45:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449    
Attachments:
Description Flags
spec tweaks none

Description Robert Kuska 2014-05-14 11:54:08 UTC 
Spec URL: http://rkuska.fedorapeople.org/pkgs/golang-github-spacemonkeygo-spacelog.spec
SRPM URL: http://rkuska.fedorapeople.org/pkgs/golang-github-spacemonkeygo-spacelog-0-0.1.gitda2b15a.fc20.src.rpm
Description: Package spacelog is a collection of interface lego bricks 
designed to help you build a flexible logging system.
Spacelog is loosely inspired by the Python logging library. 

Fedora Account System Username: rkuska


Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6848397
Comment 1 Matej Stuchlik 2014-05-14 11:58:20 UTC 
I'll take this.
Comment 2 Matej Stuchlik 2014-06-17 10:13:08 UTC 
I don't believe golang should be in BuildRequires.
Comment 3 Vincent Batts 2014-07-16 15:13:23 UTC 
Created attachment 918450 [details]
spec tweaks

The attached patch addresses the following points:
* Using the macros from the 'golang' rpm (This is one of the reasons for needing 'BuildRequires: golang')
* golang libraries are source only, so they go into -devel packages
* we use Provides: and the golang() meta to provide the library's import path
* preserve time stamps of the copied source
* Include a %check section to run code tests (despite the fact that this library does not have any tests to be run)
* set default attributes of owned files
Comment 5 Package Review 2021-05-05 00:45:33 UTC 
This is an automatic action taken by review-stats script.

The submitter account doesn't exist anymore, therefore this ticket will be closed.