Bug 1097714 - Review Request: golang-github-spacemonkeygo-spacelog - Designed to help you build a flexible logging system
Summary: Review Request: golang-github-spacemonkeygo-spacelog - Designed to help you b...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2014-05-14 11:54 UTC by Robert Kuska
Modified: 2021-05-05 00:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-05 00:45:33 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
spec tweaks (2.44 KB, patch)
2014-07-16 15:13 UTC, Vincent Batts 		no flags Details | Diff
View All

Description Robert Kuska 2014-05-14 11:54:08 UTC 
Spec URL: http://rkuska.fedorapeople.org/pkgs/golang-github-spacemonkeygo-spacelog.spec
SRPM URL: http://rkuska.fedorapeople.org/pkgs/golang-github-spacemonkeygo-spacelog-0-0.1.gitda2b15a.fc20.src.rpm
Description: Package spacelog is a collection of interface lego bricks 
designed to help you build a flexible logging system.
Spacelog is loosely inspired by the Python logging library. 

Fedora Account System Username: rkuska


Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6848397
Comment 1 Matej Stuchlik 2014-05-14 11:58:20 UTC 
I'll take this.
Comment 2 Matej Stuchlik 2014-06-17 10:13:08 UTC 
I don't believe golang should be in BuildRequires.
Comment 3 Vincent Batts 2014-07-16 15:13:23 UTC 
Created attachment 918450 [details]
spec tweaks

The attached patch addresses the following points:
* Using the macros from the 'golang' rpm (This is one of the reasons for needing 'BuildRequires: golang')
* golang libraries are source only, so they go into -devel packages
* we use Provides: and the golang() meta to provide the library's import path
* preserve time stamps of the copied source
* Include a %check section to run code tests (despite the fact that this library does not have any tests to be run)
* set default attributes of owned files
Comment 5 Package Review 2021-05-05 00:45:33 UTC 
This is an automatic action taken by review-stats script.

The submitter account doesn't exist anymore, therefore this ticket will be closed.
Note You need to log in before you can comment on or make changes to this bug.