Bug 1098027

Summary:	[AFR]: Heal command improvements
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, sasundar
Target Milestone:	---	Keywords:	Tracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:32:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	864963

Description Pranith Kumar K 2014-05-15 06:27:55 UTC

Description of problem:

1) Command: "gluster volume heal <volname> info" was not distinguishing between files undergoing I/O vs files that need self-heal. It also doesn't scale well for Big Outputs.
In 3.5 branch I already sent the re-implementation and is already merged.
- It distinguishes file data modifications (Writes/Truncates) vs data that needs healing
- Command scales well for VERY BIG output i.e. No Cli timeouts, prints all the entries.
- TODO: Distinguishing metadata(chown/chmod/setfattr etc)/entry(create/deletes) I/O vs self-heal.

2) According to the feedback we got, Commands: "gluster volume heal <volname> info healed/heal-failed" are not helpful in debugging anything. So I am thinking of deprecating these two commands.
Reasons:
- The commands only give the last 1024 entries that succeeded/failed, so most of the times users need to inspect logs.

Even without "gluster volume heal <volname> info heal/heal-failed" commands, user can gather the status using "gluster volume heal <volname> info" as below:
- If the heal succeeds, the entry will stop showing in "gluster volume heal <volname> info"
- If the heal fails, the entry keeps showing up in "gluster volume heal <volname> info" so logs give better reasons for failures.

3) "gluster volume heal <volname> info split-brain" will be re-implemented to print all the files that are in split-brain instead of the limited 1024 entries.
- One constant complaint is that even after the file is fixed from split-brain, it may still show up in the previously cached output. In this implementation the goal is to remove all the caching and compute the results afresh.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

Comment 1 Anand Avati 2014-05-15 06:33:12 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Depracate heal info healed/heal-failed commands) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-05-15 09:12:03 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Deprecate heal info healed/heal-failed commands) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2014-05-16 05:58:51 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Don't support heal info healed/heal-failed commands) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 4 Anand Avati 2014-05-19 11:56:42 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Don't support heal info healed/heal-failed commands) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 5 Anand Avati 2014-05-20 10:01:46 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Don't support heal info healed/heal-failed commands.) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 6 Anand Avati 2014-05-20 14:58:20 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Don't support heal info healed/heal-failed commands.) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 7 Anand Avati 2014-05-24 05:22:16 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Don't support heal info healed/heal-failed commands.) posted (#7) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 8 Anand Avati 2014-05-24 07:44:49 UTC

REVIEW: http://review.gluster.org/7766 (cluster/afr: Don't support heal info healed/heal-failed commands) posted (#8) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 9 Anand Avati 2014-05-28 07:00:00 UTC

COMMIT: http://review.gluster.org/7766 committed in master by Vijay Bellur (vbellur) 
------
commit bb02cfb56ae08f56df4452c2b948fa962ae1212b
Author: Pranith Kumar K <pkarampu>
Date:   Thu May 15 11:50:53 2014 +0530

    cluster/afr: Don't support heal info healed/heal-failed commands
    
    Change-Id: Iecfd3150e4f4e795e3403bcb1ac56340759a37d0
    BUG: 1098027
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/7766
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 10 Pranith Kumar K 2014-07-14 10:00:48 UTC

Only step-(2) mentioned in the bug description is addressed so far. Moving it back to assigned.

Comment 11 Niels de Vos 2014-11-11 08:32:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users