Bug 1098330

Summary:	Review Request: judy-fk - General purpose dynamic array with fixed-length keys
Product:	[Fedora] Fedora	Reporter:	Miroslav Spousta <qiq>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	lkundrak, package-review, ppisar
Target Milestone:	---	Flags:	lkundrak: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	judy-fk-1.0.6-2.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-23 11:40:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miroslav Spousta 2014-05-15 20:22:06 UTC

Spec URL: http://www.ucw.cz/~qiq/rpms/judy-fk.spec
SRPM URL: http://www.ucw.cz/~qiq/rpms/judy-fk-1.0.6-1.fc20.src.rpm
Description: Judy is a C library that provides a state-of-the-art core technology that implements a sparse dynamic array. This package adds a modified SL library that accepts fixed length byte arrays.
Fedora Account System Username: qiq

Comment 1 Miroslav Spousta 2014-05-15 20:23:42 UTC

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6851820

Comment 2 Lubomir Rintel 2014-05-16 11:09:55 UTC

Taking this for a review.
Removing FE-NEEDSPONSOR, I'm going to sponsor Mirek.

Comment 3 Lubomir Rintel 2014-05-16 11:15:17 UTC

* Package named correctly
* Packaging the latest version
* License tag correct
* License is fine for fedora
* Builds fine in mock
* Rpmlint is happy
* SPEC file is clean and legible
* Filelist sane
* Requires sane
* Provides sane

APPROVED

One minor suggestion; these are no longer required in a modern RPM:

0.) Cleaning buildroot before install

rm -rf $RPM_BUILD_ROOT

1.) %clean section altogether

%clean
rm -rf $RPM_BUILD_ROOT

2.) %defattr

%defattr(-,root,root,-)

3.) BuildRoot tag

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Comment 4 Miroslav Spousta 2014-05-16 14:11:23 UTC

Spec URL: http://www.ucw.cz/~qiq/rpms/judy-fk.spec
SRPM URL: http://www.ucw.cz/~qiq/rpms/judy-fk-1.0.6-2.fc20.src.rpm

* Fri May 16 2014 Miroslav Spousta <miroslav.spousta> 1.0.6-2
- removal of unnecessary directives from spec file

Comment 5 Miroslav Spousta 2014-05-16 14:36:52 UTC

New Package SCM Request
=======================
Package Name: judy-fk
Short Description: General purpose dynamic array with fixed-length keys
Upstream URL: http://github.com/qiq/judy-fk
Owners: qiq
Branches: f19 f20 el6 epel7

Comment 6 Gwyn Ciesla 2014-05-16 15:54:58 UTC

Git done (by process-git-requests).