Spec URL: http://www.ucw.cz/~qiq/rpms/judy-fk.spec SRPM URL: http://www.ucw.cz/~qiq/rpms/judy-fk-1.0.6-1.fc20.src.rpm Description: Judy is a C library that provides a state-of-the-art core technology that implements a sparse dynamic array. This package adds a modified SL library that accepts fixed length byte arrays. Fedora Account System Username: qiq
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6851820
Taking this for a review. Removing FE-NEEDSPONSOR, I'm going to sponsor Mirek.
* Package named correctly * Packaging the latest version * License tag correct * License is fine for fedora * Builds fine in mock * Rpmlint is happy * SPEC file is clean and legible * Filelist sane * Requires sane * Provides sane APPROVED One minor suggestion; these are no longer required in a modern RPM: 0.) Cleaning buildroot before install rm -rf $RPM_BUILD_ROOT 1.) %clean section altogether %clean rm -rf $RPM_BUILD_ROOT 2.) %defattr %defattr(-,root,root,-) 3.) BuildRoot tag BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Spec URL: http://www.ucw.cz/~qiq/rpms/judy-fk.spec SRPM URL: http://www.ucw.cz/~qiq/rpms/judy-fk-1.0.6-2.fc20.src.rpm * Fri May 16 2014 Miroslav Spousta <miroslav.spousta> 1.0.6-2 - removal of unnecessary directives from spec file
New Package SCM Request ======================= Package Name: judy-fk Short Description: General purpose dynamic array with fixed-length keys Upstream URL: http://github.com/qiq/judy-fk Owners: qiq Branches: f19 f20 el6 epel7
Git done (by process-git-requests).