Bug 1098749
Summary: | new-kernel-pkg needlessly adds LANG= to boot options | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marcos Mello <marcosfrm> | ||||||||
Component: | grubby | Assignee: | Peter Jones <pjones> | ||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 29 | CC: | bcl, bcotton, harald, liboska, marcosfrm, mattdm, myllynen, pjones, pomidorabelisima | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | 1010454 | Environment: | |||||||||
Last Closed: | 2019-11-27 19:05:40 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Marcos Mello
2014-05-18 00:36:37 UTC
It is still present in F21. Created attachment 971971 [details]
Proposed fix
Reference used: http://git.kernel.org/cgit/boot/dracut/dracut.git/tree/modules.d/10i18n/parse-i18n.sh Created attachment 981510 [details]
Proposed fix (V2)
Replaced eval with Bash's built-in variable indirection.
Created attachment 981776 [details]
Proposed fix (V3)
Drop $val. It is not needed anymore.
Ping? This is a long-standing problem created by bitroted code. I do not see a way to configure kernel-install to invoke new-kernel-pkg with --add-dracut-args, but anyway at least let's unbreak it. If one needs the dracut kernel args, teach kernel-install some config option for that. This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 It would indeed be nice to have this fixed in F22, especially now that a patch proposal already exists. Thanks. F22 is already gone at this point. Let's hope for F23! Marko, can't you take a look at this? F23 is almost beta now. This looks like to be pending Peter Jones to review the patch attached earlier this year. Peter? (In reply to Marcos Mello from comment #12) > https://github.com/rhinstaller/grubby/pull/6 Merged upstream now: https://github.com/rhinstaller/grubby/commit/a6843cb0fc122a3bd8a7e4067c3783ef4ce69f33 https://github.com/rhinstaller/grubby/commit/5f023ff0d6cb5ad46056d89d64c11da9782322cf Thanks. This is still an issue with Fedora 24, the upstream patches have not yet landed. This is still an issue with Fedora 25 Beta. Peter: all what should be needed is to rebuild grubby with the patch already included in upstream. Thanks. I posted some time ago https://github.com/rhinstaller/grubby/issues/14 if RHEL 6 compatibility is still necessary. This message is a reminder that Fedora 24 is nearing its end of life. Approximately 2 (two) weeks from now Fedora will stop maintaining and issuing updates for Fedora 24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '24'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 24 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Sadly, after more than three and half years since the initial report, it is no more a surprise that this straightforward case is still an issue with the latest release, this time being Fedora 26. Please assign to a more responsive maintainer if you know any. Thanks. This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'. This is still an issue with Fedora 27 Beta. What's going on? Is grubby unmaintained? This is still an issue with Fedora 28. Adjusting title a bit to make it hopefully more clear, adding PrioritizedBug to Whiteboard as per https://fedoraproject.org/wiki/Fedora_Program_Management/Prioritized_bugs_and_issues_-_the_process to hopefully get more attention to this. The earlier BZ (pasted larger above as well) about this perhaps also provides some additional context: https://bugzilla.redhat.com/show_bug.cgi?id=1010454 @pjones: we would really appreciate your comments here. Thanks. Is there an actual harm here, or is it entirely aesthetic? In order for Prioritized Bugs to really work, we need to keep it focused on issues with big impact. That doesn't mean thousands of little annoying problems shouldn't get fixed, but we can't solve them all with that particular hammer. It is certainly an aesthetic and a correctness issue but whether there's an actual harm may be a matter of interpretation. Let's take a concrete example: Installing Fedora 28 using Finnish will cause LANG=fi_FI.UTF-8 to be added to kernel command line via grub.cfg. If changing system locale later with localectl(1), only /etc/locale.conf is updated, not grub.cfg. There is thus discrepancy of kernel command line arguments and locale actually being used. Since LANG is not set in /etc/default/grub using grubby(8) is also inadequate, one would need to locate grub.cfg (path differs on BIOS vs EFI systems), and change/remove all LANG entries there to avoid this discrepancy. Thanks. Rejected as a PrioritizedBug. The upcoming grubby rework should address this issue. This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle. Changing version to '29'. This message is a reminder that Fedora 29 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '29'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 29 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. I am happy to confirm this seems to be finally resolved with Fedora 31. After fresh Fedora 31 installation using the release ISO and all-defaults no LANG option is in /proc/cmdline. After upgrading to the latest packages (which include a kernel upgrade as well) and rebooting, still no LANG in /proc/cmdline. |