Bug 1101556

sent patches:
https://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg00139.html

the patches have just been merged in upstream, delaying to rhel 7.3

Hi Marc,
do we want to have some default config file available in rhel 7.3? Or will we just go with supporting this feature?

(In reply to Miroslav Rezanina from comment #3)
> Hi Marc,
> do we want to have some default config file available in rhel 7.3? Or will
> we just go with supporting this feature?

I don't think it's necessary, as qemu-ga rhel package ships with a sysconfig file. We would either have to break or duplicate this configuration and this could confuse users. Perhaps the next major rhel release could switch to the new configuration file and drop sysconfig file?

Hi Marc,

I tested on kernel-3.10.0-422.el7.x86_64/qemu-guest-agent-2.5.0-2.el7.x86_64 as below steps:

Guest:
1. yum install qemu-gest-agent
2. systemctl stop qemu-guest-agent.service
3. cat >/etc/qemu/qemu-ga.conf <<EOF
[general]
blacklist=guest-info
4. qemu-ga

Host:
5: nc -U /home/chanel1
{"execute":"guest-info"}
6:
{"execute":"guest-ping"}
{"return": {}}

after step 5, the expected result:
{"error": {"class": "GenericError", "desc":
"The command guest-info has been disabled for this instance"}}

but the actual result: blacklist doesn't work
{"return": {"version": "2.5.0", "supported_commands": [{"enabled": true, "name": "guest-sync-delimited", "success-response": true}, {"enabled": true, "name": "guest-sync", "success-response": true}, {"enabled": true, "name": "guest-suspend-ram", "success-response": false}, {"enabled": true, "name": "guest-suspend-hybrid", "success-response": false}, {"enabled": true, "name": "guest-suspend-disk", "success-response": false}, {"enabled": true, "name": "guest-shutdown", "success-response": false}, {"enabled": true, "name": "guest-set-vcpus", "success-response": true}, {"enabled": true, "name": "guest-set-user-password", "success-response": true}, {"enabled": true, "name": "guest-set-time", "success-response": true}, {"enabled": true, "name": "guest-set-memory-blocks", "success-response": true}, {"enabled": true, "name": "guest-ping", "success-response": true}, {"enabled": true, "name": "guest-network-get-interfaces", "success-response": true}, {"enabled": true, "name": "guest-info", "success-response": true}, {"enabled": true, "name": "guest-get-vcpus", "success-response": true}, {"enabled": true, "name": "guest-get-time", "success-response": true}, {"enabled": true, "name": "guest-get-memory-blocks", "success-response": true}, {"enabled": true, "name": "guest-get-memory-block-info", "success-response": true}, {"enabled": true, "name": "guest-get-fsinfo", "success-response": true}, {"enabled": true, "name": "guest-fstrim", "success-response": true}, {"enabled": true, "name": "guest-fsfreeze-thaw", "success-response": true}, {"enabled": true, "name": "guest-fsfreeze-status", "success-response": true}, {"enabled": true, "name": "guest-fsfreeze-freeze-list", "success-response": true}, {"enabled": true, "name": "guest-fsfreeze-freeze", "success-response": true}, {"enabled": false, "name": "guest-file-write", "success-response": true}, {"enabled": false, "name": "guest-file-seek", "success-response": true}, {"enabled": false, "name": "guest-file-read", "success-response": true}, {"enabled": false, "name": "guest-file-open", "success-response": true}, {"enabled": false, "name": "guest-file-flush", "success-response": true}, {"enabled": false, "name": "guest-file-close", "success-response": true}, {"enabled": false, "name": "guest-exec-status", "success-response": true}, {"enabled": false, "name": "guest-exec", "success-response": true}]}}


I found this issue has fixed by commit e236d060cba8d2d6d26a7e076c895d2a6812dafb

And if the blacklist in /etc/sysconfig/qemu-ga, it works well.


I want to confirm with you:

1. if the test steps are ok?, if miss some steps, please tell me the correct steps
2. the config files /etc/sysconfig/qemu-ga and /etc/qemu/qemu-ga.conf are all in  use right? I fond if I start the qemu-guest-agent.service, /etc/sysconfig/qemu-ga will be used in the service.


Thank you very much.
Xueqiang

(In reply to Xueqiang Wei from comment #6)

> 1. if the test steps are ok?, if miss some steps, please tell me the correct
> steps

The configuration location is wrong: /etc/qemu-ga/qemu-ga.conf

(In reply to Marc-Andre Lureau from comment #7)
> (In reply to Xueqiang Wei from comment #6)
> 
> > 1. if the test steps are ok?, if miss some steps, please tell me the correct
> > steps
> 
> The configuration location is wrong: /etc/qemu-ga/qemu-ga.conf

Verified, the test result is passed. Thanks.

BZ moved to post due to missing documentation for the change. Adding missing man file will be handled with this BZ.

to back the exception request:
this is very low risk, and easy to check

Fix included in qemu-guest-agent-2.5.0-3.el7

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2303.html