Bug 1103034
| Summary: | Review Request: python-django-stopforumspam - Django middleware for blocking IPs listed in stopforumspam.com | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-django-stopforumspam-1.4.1-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-11 16:26:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ankur Sinha (FranciscoD)
2014-05-30 06:00:55 UTC
Review: + Package builds successful in mock f21 + rpmlint on generated rpms gave python-django-stopforumspam.noarch: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight python-django-stopforumspam.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight python-django-stopforumspam.noarch: W: spelling-error %description -l en_US com's -> con's, om's, come's python-django-stopforumspam.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-django-stopforumspam.noarch: W: spelling-error %description -l en_US sfsupdate -> update python-django-stopforumspam.src: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight python-django-stopforumspam.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight python-django-stopforumspam.src: W: spelling-error %description -l en_US com's -> con's, om's, come's python-django-stopforumspam.src: W: spelling-error %description -l en_US py -> pt, p, y python-django-stopforumspam.src: W: spelling-error %description -l en_US sfsupdate -> update 2 packages and 0 specfiles checked; 0 errors, 10 warnings. ==> no issues here + Source verified with usptream tarball as (sha256sum) srpm tarball: 8b329b80d30cd83b97a6e8049fb0f51206215d5ca5255ff3ebe4bd2174717813 upstream tarball : 8b329b80d30cd83b97a6e8049fb0f51206215d5ca5255ff3ebe4bd2174717813 + License is BSD as per given on upstream URL Suggestions: 1) Decide if you need this package in EPEL or not otherwise all the cleanup guidelines should be followed like a) no need of removal of buildroot in %install b) python2_site* macros at top of spec file are not needed 2) Use http://fedoraproject.org/wiki/Packaging:Python#Macros in %files change %{python_sitelib} to %{python2_sitelib} APPROVED. Hi Paragn, Thank you for the quick review. I'm only going to push to Fedora at the moment, but I expect the package to be used for Ask Fedora sometime in the future. We'll request more branches if needed. Thanks, Warm regards, Ankur New Package SCM Request ======================= Package Name: python-django-stopforumspam Short Description: Django middleware for blocking IPs listed in stopforumspam Upstream URL: https://pypi.python.org/pypi/stopforumspam/ Owners: ankursinha Branches: f20 InitialCC: Git done (by process-git-requests). python-django-stopforumspam-1.4.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-django-stopforumspam-1.4.1-1.fc20 python-django-stopforumspam-1.4.1-1.fc20 has been pushed to the Fedora 20 testing repository. python-django-stopforumspam-1.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: python-django-stopforumspam New Branches: el6 Owners: ankursinha InitialCC: Required by askbot for Fedora infrastructure. Git done (by process-git-requests). |