Bug 1103034 - Review Request: python-django-stopforumspam - Django middleware for blocking IPs listed in stopforumspam.com
Summary: Review Request: python-django-stopforumspam - Django middleware for blocking ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-30 06:00 UTC by Ankur Sinha (FranciscoD)
Modified: 2014-08-11 12:31 UTC (History)
2 users (show)

Fixed In Version: python-django-stopforumspam-1.4.1-1.fc20
Clone Of:
Environment:
Last Closed: 2014-06-11 16:26:59 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2014-05-30 06:00:55 UTC
Spec URL: http://ankursinha.fedorapeople.org/python-django-stopforumspam/python-django-stopforumspam.spec
SRPM URL: http://ankursinha.fedorapeople.org/python-django-stopforumspam/python-django-stopforumspam-1.4.1-1.fc21.src.rpm

Description: 
Tired of comment spam, form spam and dumb crawlers? A django application that
provides middleware for blocking IPs listed in stopforumspam.com's database. A
simple management command is provided for updating the database:

    manage.py sfsupdate [--force]

Using this command, all IPs are stored in Django models. Using django-admin,
it's possible to add your own extra IP addresses on a permanent database.



Fedora Account System Username: ankursinha


Additional information:
[asinha@ankur-laptop  SRPMS]$ !rpmlint
rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
python-django-stopforumspam.noarch: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US com's -> con's, om's, come's
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US sfsupdate -> update
python-django-stopforumspam.src: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.src: W: spelling-error %description -l en_US com's -> con's, om's, come's
python-django-stopforumspam.src: W: spelling-error %description -l en_US py -> pt, p, y
python-django-stopforumspam.src: W: spelling-error %description -l en_US sfsupdate -> update
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
[asinha@ankur-laptop  SRPMS]$

Comment 1 Parag AN(पराग) 2014-05-30 07:31:28 UTC
Review:

+ Package builds successful in mock f21

+ rpmlint on generated rpms gave
python-django-stopforumspam.noarch: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US com's -> con's, om's, come's
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python-django-stopforumspam.noarch: W: spelling-error %description -l en_US sfsupdate -> update
python-django-stopforumspam.src: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
python-django-stopforumspam.src: W: spelling-error %description -l en_US com's -> con's, om's, come's
python-django-stopforumspam.src: W: spelling-error %description -l en_US py -> pt, p, y
python-django-stopforumspam.src: W: spelling-error %description -l en_US sfsupdate -> update
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
==> no issues here

+ Source verified with usptream tarball as (sha256sum)
srpm tarball: 8b329b80d30cd83b97a6e8049fb0f51206215d5ca5255ff3ebe4bd2174717813
upstream tarball : 8b329b80d30cd83b97a6e8049fb0f51206215d5ca5255ff3ebe4bd2174717813

+ License is BSD as per given on upstream URL 

Suggestions:
1) Decide if you need this package in EPEL or not otherwise all the cleanup guidelines should be followed like
   a) no need of removal of buildroot in %install
   b) python2_site* macros at top of spec file are not needed

2) Use http://fedoraproject.org/wiki/Packaging:Python#Macros in %files
change %{python_sitelib} to %{python2_sitelib}

APPROVED.

Comment 2 Ankur Sinha (FranciscoD) 2014-05-30 10:06:31 UTC
Hi Paragn,

Thank you for the quick review. I'm only going to push to Fedora at the moment, but I expect the package to be used for Ask Fedora sometime in the future. We'll request more branches if needed. 

Thanks,
Warm regards,
Ankur

Comment 3 Ankur Sinha (FranciscoD) 2014-05-30 10:10:04 UTC
New Package SCM Request
=======================
Package Name: python-django-stopforumspam
Short Description: Django middleware for blocking IPs listed in stopforumspam
Upstream URL: https://pypi.python.org/pypi/stopforumspam/
Owners: ankursinha
Branches: f20
InitialCC:

Comment 4 Gwyn Ciesla 2014-05-30 11:51:47 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-06-02 09:18:36 UTC
python-django-stopforumspam-1.4.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-django-stopforumspam-1.4.1-1.fc20

Comment 6 Fedora Update System 2014-06-02 22:57:35 UTC
python-django-stopforumspam-1.4.1-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 7 Fedora Update System 2014-06-11 16:26:59 UTC
python-django-stopforumspam-1.4.1-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 8 Ankur Sinha (FranciscoD) 2014-08-10 04:07:25 UTC
Package Change Request
======================
Package Name: python-django-stopforumspam
New Branches: el6 
Owners: ankursinha
InitialCC: 

Required by askbot for Fedora infrastructure.

Comment 9 Gwyn Ciesla 2014-08-11 12:31:23 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.