Bug 1103524
Summary: | Change rabbitmq-server systemd service to Type=notify | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> | ||||
Component: | rabbitmq-server | Assignee: | Peter Lemenkov <lemenkov> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | apevec, erlang, hubert.plociniczak, jeckersb, lemenkov, ohadlevy, rjones, s | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | rabbitmq-server-3.1.5-9.fc21 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | 1059913 | Environment: | |||||
Last Closed: | 2014-07-02 16:05:27 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 1059913, 1104604 | ||||||
Bug Blocks: | 1086146 | ||||||
Attachments: |
|
Description
Peter Lemenkov
2014-06-01 15:52:41 UTC
Do you have a patch to rabbitmq for this yet? I've taken a stab at it but it doesn't seem to be working. I can barely function in erlang so I've probably done something wrong. https://github.com/jeckersb/rabbitmq-server/commit/13c5215b6fb3c13e71748bfe4b1d6563aa606a9a (In reply to John Eckersberg from comment #1) > Do you have a patch to rabbitmq for this yet? I've taken a stab at it but > it doesn't seem to be working. I can barely function in erlang so I've > probably done something wrong. > > https://github.com/jeckersb/rabbitmq-server/commit/ > 13c5215b6fb3c13e71748bfe4b1d6563aa606a9a I'll review your patch shortly. (In reply to John Eckersberg from comment #1) > Do you have a patch to rabbitmq for this yet? I've taken a stab at it but > it doesn't seem to be working. I can barely function in erlang so I've > probably done something wrong. > > https://github.com/jeckersb/rabbitmq-server/commit/ > 13c5215b6fb3c13e71748bfe4b1d6563aa606a9a Looks good to me. I've tried and it works quite fine. Perhaps you forgot to change Type=notify in rabbitmq-server.service and/or reload config with systemctl daemon-reload. I've backported your patch to 3.1.5: http://peter.fedorapeople.org/rabbitmq-server-0001-Add-systemd-notify-support.patch Thanks for the review. I tried it again this morning on a fresh VM and it works fine for me now. Must have been something wrong in my local setup. Created attachment 909630 [details]
patch for rawhide branch
Here's the patch for the spec, the patch, and the updated systemd service file for the master branch in git. I don't have perms to push to it otherwise I'd do it myself.
Note that we'll need erland-sd_notify built before we do a new rabbitmq-server build, since the sd_notify package is now a Requires for rabbitmq-server.
(In reply to John Eckersberg from comment #5) > Created attachment 909630 [details] > patch for rawhide branch > > Here's the patch for the spec, the patch, and the updated systemd service > file for the master branch in git. I don't have perms to push to it > otherwise I'd do it myself. Just request commit access and I'll approve asap: https://admin.fedoraproject.org/pkgdb/package/rabbitmq-server/ I personally love when more people are involved! > Note that we'll need erland-sd_notify built before we do a new > rabbitmq-server build, since the sd_notify package is now a Requires for > rabbitmq-server. Yes, I'm still waiting for the "process-git-requests" approval. (In reply to Peter Lemenkov from comment #6) > (In reply to John Eckersberg from comment #5) > > Created attachment 909630 [details] > > patch for rawhide branch > > > > Here's the patch for the spec, the patch, and the updated systemd service > > file for the master branch in git. I don't have perms to push to it > > otherwise I'd do it myself. > > Just request commit access and I'll approve asap: > > https://admin.fedoraproject.org/pkgdb/package/rabbitmq-server/ Err, well, unexpected issue - it turned out that I'm not in charge there. So we have to have FAS approval first. (In reply to John Eckersberg from comment #5) > Created attachment 909630 [details] > patch for rawhide branch > > Here's the patch for the spec, the patch, and the updated systemd service > file for the master branch in git. I don't have perms to push to it > otherwise I'd do it myself. > > Note that we'll need erland-sd_notify built before we do a new > rabbitmq-server build, since the sd_notify package is now a Requires for > rabbitmq-server. Good news everyone! We've just regained control over RabbitMQ! John, you have a go! https://www.youtube.com/watch?v=odiMeEhfi9I |