Bug 1103578
Summary: | varnish bundles zlib | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
Component: | varnish | Assignee: | Ingvar Hagelund <ingvar> |
Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 38 | CC: | ingvar, mmuzikar, mmuzila |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | ingvar:
needinfo?
(mmuzila) |
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-07-19 11:35:44 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 504493 |
Description
Ville Skyttä
2014-06-02 06:50:01 UTC
This libvgz is a patched variant of zlib, with highly varnish specific changes (thus the rename). The changes are not large, but the standard zlib version can't be used. A way to resolve this could be to try to push the changes upstream, though as they are quite application specific, I guess they won't be included. Another variant may be to try to push the changes for the fedora version of zlib, but that seems a bit strange as well. I'm a bit unsure about what to do with this. I'll try upstream first, I guess. Ingvar Cut from IRC with varnish upstream: 11:24 < ingvar> are these (zlib) changes extremely varnish specific, or could other zlib users use them as new features? 11:24 < ingvar> (I guess you see where I'm working this :-) 11:25 < phk> ingvar, the changes you should look for are the start_bit, stop_bit and last_bit changes. 11:26 < phk> ingvar, they are not in any way general, so I didn't even want to try to push the up stream. 11:26 < phk> ingvar, you are of course welcome to try to push them upstream if you want... 11:27 < ingvar> If no one can use them other than varnish, they'll probably not be included 11:28 < phk> ingvar, well, they _can_ use them, but people would have to be insane enough to edit gzip files together before then need that info. 11:28 < ingvar> heh 11:28 < phk> libz has some rather marginal stuff, but I perceive this to be past even their threshold 11:29 < phk> ingvar, and for what it's worth: I applaud them (fedora) for their "no copy&paste libraries" policy. I have contacted upstream (twice), via the general contact mail address as announced on the homepage, but haven't received any reply, so I'll try the devel list. I'll post as soon as my subscription is active (it seems to be manually moderated). Meanwhile, I've produced a minimal patch for zlib: http://users.linpro.no/ingvar/varnish/varnish_zlib_patch If upstream never answers, it might be possible to apply this to the Fedora zlib package. Ingvar If patching zlib is required, please contact zlib upstream instead of (or in addition to or before) the Fedora zlib maintainers. I finally got post access to the zlib dev mailing list. My request was received last week with one comment on how this could affect efficiency in zlib, and then utter silence. So, still waiting for upstream. Ingvar This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. This message is a reminder that Fedora 25 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '25'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 25 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. It might be possible to fix this upstream in varnish. I have added a github issue to follow that up: https://github.com/varnishcache/varnish-cache/issues/2512 This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle. Changing version to 33. This message is a reminder that Fedora 33 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '33'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 33 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle. Changing version to 36. This message is a reminder that Fedora Linux 36 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '36'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 36 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed. This message is a reminder that Fedora Linux 38 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 38 on 2024-05-21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '38'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 38 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed. I didn't get any traction on this from upstream zlib 10 years ago, and upstream varnish said back in 2018 that it is difficult to fix this in varnish. http://madler.net/pipermail/zlib-devel_madler.net/2015-January/003260.html https://github.com/varnishcache/varnish-cache/issues/2512 https://github.com/varnishcache/varnish-cache/wiki/VIP21:-Avoid-modified-Zlib Only possible solution left is to push varnish specific patches to fedora's zlib.Is this something that is wanted or possible, @mmuzikar ? (In reply to Ingvar Hagelund from comment #17) > I didn't get any traction on this from upstream zlib 10 years ago, and > upstream varnish said back in 2018 that it is difficult to fix this in > varnish. > > http://madler.net/pipermail/zlib-devel_madler.net/2015-January/003260.html > https://github.com/varnishcache/varnish-cache/issues/2512 > https://github.com/varnishcache/varnish-cache/wiki/VIP21:-Avoid-modified-Zlib > > Only possible solution left is to push varnish specific patches to fedora's > zlib.Is this something that is wanted or possible, @mmuzikar ? You probably wanted to tag mmuzila. I wasn't involved in this and won't be able to help. Best of luck though. |