Red Hat Bugzilla – Bug 1103578
varnish bundles zlib
Last modified: 2017-12-08 09:00:34 EST
varnish bundles zlib in lib/libvgz. According to lib/libvgz/README it is a modified version so chances are that a FPC exception and marking it in the specfile is the way forward here.
This libvgz is a patched variant of zlib, with highly varnish specific changes (thus the rename). The changes are not large, but the standard zlib version can't be used.
A way to resolve this could be to try to push the changes upstream, though as they are quite application specific, I guess they won't be included.
Another variant may be to try to push the changes for the fedora version of zlib, but that seems a bit strange as well.
I'm a bit unsure about what to do with this. I'll try upstream first, I guess.
Cut from IRC with varnish upstream:
11:24 < ingvar> are these (zlib) changes extremely varnish specific, or could other zlib users use them as new features?
11:24 < ingvar> (I guess you see where I'm working this :-)
11:25 < phk> ingvar, the changes you should look for are the start_bit, stop_bit and last_bit changes.
11:26 < phk> ingvar, they are not in any way general, so I didn't even want to try to push the up stream.
11:26 < phk> ingvar, you are of course welcome to try to push them upstream if you want...
11:27 < ingvar> If no one can use them other than varnish, they'll probably not be included
11:28 < phk> ingvar, well, they _can_ use them, but people would have to be insane enough to edit gzip files together before then need that info.
11:28 < ingvar> heh
11:28 < phk> libz has some rather marginal stuff, but I perceive this to be past even their threshold
11:29 < phk> ingvar, and for what it's worth: I applaud them (fedora) for their "no copy&paste libraries" policy.
I have contacted upstream (twice), via the general contact mail address as announced on the homepage, but haven't received any reply, so I'll try the devel list. I'll post as soon as my subscription is active (it seems to be manually moderated).
Meanwhile, I've produced a minimal patch for zlib:
If upstream never answers, it might be possible to apply this to the Fedora zlib package.
If patching zlib is required, please contact zlib upstream instead of (or in addition to or before) the Fedora zlib maintainers.
I finally got post access to the zlib dev mailing list. My request was received last week with one comment on how this could affect efficiency in zlib, and then utter silence.
So, still waiting for upstream.
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.
More information and reason for this action is here:
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
Thank you for reporting this bug and we are sorry it could not be fixed.
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora 'version'
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
It might be possible to fix this upstream in varnish. I have added a github issue to follow that up: