Bug 1103768

Summary: Commnon deployer for JavaScript and skin services
Product: [JBoss] JBoss Enterprise Portal Platform 6 Reporter: Peter Palaga <ppalaga>
Component: PortalAssignee: Peter Palaga <ppalaga>
Status: CLOSED UPSTREAM QA Contact: Marek Baluch <mbaluch>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: epp-bugs, tkyjovsk
Target Milestone: ER03   
Target Release: 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-10 03:36:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Peter Palaga 2014-06-02 13:50:38 UTC 
Description of problem:
Cloned from https://issues.jboss.org/browse/GTNPORTAL-3502 so that it gets QA'd properly.
At present, there are two independent deployers for JavaScript and skin services: GateInSkinConfigDeployer and JavascriptConfigDeployer. There are two problems with that:
(1) Both of them parse gatein-resources.xml independently, which is a performance drawback.
(2) They can succeed or fail independently, e.g. in case there is some meaningless declaration in gatein-resources.xml, which can lead to an inconsistent state of the portal.
An ideal solution for (2) would be to rollback deployment of the whole web application, but unfortunately, the present design of the portal does not allow for that. Therefore, I propose to keep at least the two services consistent by introducing a common deployer, that will grant that resources will either succeed to be added to both or to none. Problem (1) will be solved by that too.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Peter Palaga 2014-06-02 13:52:16 UTC 
https://github.com/gatein/gatein-portal/pull/863 was merged in upstream.
Comment 3 Peter Palaga 2014-06-25 12:44:34 UTC 
Petře, you asked for steps to reproduce for manual testing...

I have added a couple of unit tests [1] in upstream, that will be included in JBoss Portal 6.2.0.ER4. A manual test would basically do the same, i.e.:

(1) Add two interdependent apps, then remove the one that the other one depends on, and then add it back again.

(2) Add apps with gatein-resources.xml broken in several ways

So given that there are unit tests covering those scenarios, I'd say that there is no need to test manually again. You could perhaps review the tests and check their correctness.

[1] https://github.com/gatein/gatein-portal/blob/fb8a360d682b8a3579080f00d1d32166a1c1372f/component/web/resources/src/test/java/org/exoplatform/portal/resource/TestGateInResourcesDeployer.java#L90
Comment 5 Tomas Kyjovsky 2014-08-07 16:20:49 UTC 
Peter, all 3 unit tests you added for ER4 passed. Moving this to VERIFIED.

https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/epp6_unit_tests_epp6_oraclejdk1.7/67/testReport/org.exoplatform.portal.resource/TestGateInResourcesDeployer/
Comment 8 Red Hat Bugzilla 2025-02-10 03:36:00 UTC 
This product has been discontinued or is no longer tracked in Red Hat Bugzilla.