Description of problem: Cloned from https://issues.jboss.org/browse/GTNPORTAL-3502 so that it gets QA'd properly. At present, there are two independent deployers for JavaScript and skin services: GateInSkinConfigDeployer and JavascriptConfigDeployer. There are two problems with that: (1) Both of them parse gatein-resources.xml independently, which is a performance drawback. (2) They can succeed or fail independently, e.g. in case there is some meaningless declaration in gatein-resources.xml, which can lead to an inconsistent state of the portal. An ideal solution for (2) would be to rollback deployment of the whole web application, but unfortunately, the present design of the portal does not allow for that. Therefore, I propose to keep at least the two services consistent by introducing a common deployer, that will grant that resources will either succeed to be added to both or to none. Problem (1) will be solved by that too. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
https://github.com/gatein/gatein-portal/pull/863 was merged in upstream.
Petře, you asked for steps to reproduce for manual testing... I have added a couple of unit tests [1] in upstream, that will be included in JBoss Portal 6.2.0.ER4. A manual test would basically do the same, i.e.: (1) Add two interdependent apps, then remove the one that the other one depends on, and then add it back again. (2) Add apps with gatein-resources.xml broken in several ways So given that there are unit tests covering those scenarios, I'd say that there is no need to test manually again. You could perhaps review the tests and check their correctness. [1] https://github.com/gatein/gatein-portal/blob/fb8a360d682b8a3579080f00d1d32166a1c1372f/component/web/resources/src/test/java/org/exoplatform/portal/resource/TestGateInResourcesDeployer.java#L90
Peter, all 3 unit tests you added for ER4 passed. Moving this to VERIFIED. https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/epp6_unit_tests_epp6_oraclejdk1.7/67/testReport/org.exoplatform.portal.resource/TestGateInResourcesDeployer/