Bug 1104954

REVIEW: http://review.gluster.org/7984 (geo-rep: gid is not set in entry ops) posted (#1) for review on master by Aravinda VK (avishwan)

REVIEW: http://review.gluster.org/8959 (feature/gfid-access: Storing correct uid/gid in frame->root.) posted (#1) for review on master by ajeet jha (ajha)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing a SETATTR entries.) posted (#1) for review on master by Kotresh HR (khiremat)

REVIEW: http://review.gluster.org/8959 (feature/gfid-access: Storing correct uid/gid in frame->root.) posted (#2) for review on master by Aravinda VK (avishwan)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing a SETATTR entries.) posted (#2) for review on master by Kotresh HR (khiremat)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing a SETATTR entries.) posted (#3) for review on master by Kotresh HR (khiremat)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing a SETATTR entries.) posted (#4) for review on master by Kotresh HR (khiremat)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing SETATTR entries.) posted (#5) for review on master by Kotresh HR (khiremat)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing SETATTR entries.) posted (#6) for review on master by Kotresh HR (khiremat)

REVIEW: http://review.gluster.org/8964 (feature/changelog: Fix changelog missing SETATTR entries.) posted (#7) for review on master by Kotresh HR (khiremat)

COMMIT: http://review.gluster.org/7984 committed in master by Venky Shankar (vshankar) 
------
commit 3993728390cc50390a527f5f01d6dcf3e6293110
Author: Aravinda VK <avishwan>
Date:   Thu Jun 5 11:12:22 2014 +0530

    geo-rep: gid is not set in entry ops
    
    uid is sent in place of gid while CREATE and
    MKDIR.
    
    Change-Id: Icd1072cb9dcbfc1f419a3cdd456f3d02168175fa
    BUG: 1104954
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/7984
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

COMMIT: http://review.gluster.org/8964 committed in master by Venky Shankar (vshankar) 
------
commit 5ae0df29b4e590d9a8a5f3c8f9e98cc944b006cf
Author: Kotresh HR <khiremat>
Date:   Wed Oct 22 12:09:01 2014 +0530

    feature/changelog: Fix changelog missing SETATTR entries.
    
    Problem: Valid SETATTR entries are missing in changelog when more
             than one metadata operation happen on same inode within
             changelog roll-over time.
    
    Cause: Metadata entries with fop num being GF_FOP_NULL are logged
           in changelog which is of no use. Since slice version
           checking is done for metadata entries to avoid logging of
           subsequent entries of same inode falling into same
           changelog, if the entry with GF_FOP_NULL is logged first,
           subsequent valid ones will be missed.
    
    Solution: Have a boundary condition to log only those fops whose fop
              number falls between GF_FOP_NULL and GF_FOP_MAXVALUE.
    
    Change-Id: Iff585ea573ac5e521a361541c6646225943f0b2d
    BUG: 1104954
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/8964
    Reviewed-by: Aravinda VK <avishwan>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Patches:
http://review.gluster.org/#/c/7984/
http://review.gluster.org/#/c/8964/

With these three patches, I tested following cases and worked as expected.

gvm - Master volume
gvs - Slave volume
/mnt/gvm - Master mount
/mnt/gvs - Slave mount

Case 1:
=======
cd /mnt/gvm
touch f1

ls -l /mnt/gvm
-rw-r--r-- 1 root     root      0 Oct 22 16:04 f1

ls -l /mnt/gvm
-rw-r--r-- 1 root     root      0 Oct 22 16:05 f1


Case 2:
=======
cd /mnt/gvm
mkdir dir1
chown -R aravinda dir1
su aravinda
cd /mnt/gvm/dir1
touch dir1_f1

ls -l /mnt/gvm/dir1
-rw-rw-r-- 1 aravinda aravinda 0 Oct 22 16:07 dir1_f1

ls -l /mnt/gvs/dir1
-rw-rw-r-- 1 aravinda aravinda 0 Oct 22 16:07 dir1_f1

Case 3:
=======
cp -p /etc/motd /mnt/gvm/

ls -l /mnt/gvm/
-rw-r--r-- 1 root     root      0 Jun  7  2013 motd

ls -l /mnt/gvs/
-rw-r--r-- 1 root     root      0 Oct 22 16:57 motd

Case 4:
=======
touch /tmp/tmp_f1
chmod 0400 /tmp/tmp_f1
chown aravinda.users /tmp/t_f1
cp -p /tmp/t_f1 /mnt/gvm/

ls -l /mnt/gvm/
-r-------- 1 aravinda  users     0 Oct 22 16:59 t_f1

ls -l /mnt/gvs/
-r-------- 1 aravinda  users     0 Oct 22 17:02 t_f1

REVIEW: http://review.gluster.org/9051 (feature/gfid-access: Always send setattr down in overloaded setxattr.) posted (#1) for review on master by Kotresh HR (khiremat)

COMMIT: http://review.gluster.org/9051 committed in master by Venky Shankar (vshankar) 
------
commit a3252b9d8c4cc024b5528ca88076c7e33aecad38
Author: Kotresh HR <khiremat>
Date:   Wed Nov 5 12:36:32 2014 +0530

    feature/gfid-access: Always send setattr down in overloaded setxattr.
    
    Problem: File ownership is not being preserved for root in geo-rep
             mountbroker setup.
    
    Analysis and Cause:
             Entry creations for geo-rep is overloaded in ga_setxattr.
             It happens in two phase, entry creation followed by setattr
             to preserve ownership as in master.
    
             If uid and gid of file being synced is root, setattr was
             not being sent down. Since, the file creation happens with
             non-root user in mountborker geo-rep setup, if setattr is
             not done explicitly, file ownership is not preserved for root.
    
    Solution:
             Always pass setattr down in overloaded ga_setxattr.
    
    Change-Id: I062215c1b2379d515f28ec7f271077ad37182c7e
    BUG: 1104954
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/9051
    Reviewed-by: Aravinda VK <avishwan>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

*** Bug 1024467 has been marked as a duplicate of this bug. ***

*** Bug 1146263 has been marked as a duplicate of this bug. ***

This bug is getting closed because a release has been made available that
should address the reported issue. In case the problem is still not fixed with
glusterfs-3.7.0, please open a new bug report.