Bug 1159213 - Dist-geo-rep : geo-rep doesn't preserve the ownership while syncing entry operations to slave through mount-broker.
Summary: Dist-geo-rep : geo-rep doesn't preserve the ownership while syncing entry op...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: geo-replication
Version: 3.6.0
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ---
Assignee: Aravinda VK
QA Contact:
URL:
Whiteboard:
Depends On: 1104061 1104954
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-31 08:50 UTC by Aravinda VK
Modified: 2015-05-18 10:47 UTC (History)
10 users (show)

Fixed In Version: glusterfs-3.6.3beta1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1104954
Environment:
Last Closed: 2015-05-18 10:47:13 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2014-10-31 08:54:39 UTC
REVIEW: http://review.gluster.org/9027 (geo-rep: gid is not set in entry ops) posted (#1) for review on release-3.6 by Aravinda VK (avishwan)

Comment 2 Anand Avati 2014-10-31 08:54:42 UTC
REVIEW: http://review.gluster.org/9028 (feature/changelog: Fix changelog missing SETATTR entries.) posted (#1) for review on release-3.6 by Aravinda VK (avishwan)

Comment 3 Anand Avati 2014-11-10 08:51:37 UTC
REVIEW: http://review.gluster.org/9083 (feature/gfid-access: Always send setattr down in overloaded setxattr.) posted (#1) for review on release-3.6 by Kotresh HR (khiremat)

Comment 4 Anand Avati 2014-11-13 10:12:10 UTC
COMMIT: http://review.gluster.org/9027 committed in release-3.6 by Venky Shankar (vshankar) 
------
commit 6686deb9058ec62721868dd4e9f35a9245b9b5c7
Author: Aravinda VK <avishwan>
Date:   Thu Jun 5 11:12:22 2014 +0530

    geo-rep: gid is not set in entry ops
    
    uid is sent in place of gid while CREATE and
    MKDIR.
    
    BUG: 1159213
    Change-Id: I711f383cef9de7467df9e60774d880eb5e1a642a
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/7984
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/9027

Comment 5 Anand Avati 2014-11-14 05:54:05 UTC
COMMIT: http://review.gluster.org/9028 committed in release-3.6 by Venky Shankar (vshankar) 
------
commit 61f1a8fa322e4309989a9a5e022cad2bda55b751
Author: Kotresh HR <khiremat>
Date:   Wed Oct 22 12:09:01 2014 +0530

    feature/changelog: Fix changelog missing SETATTR entries.
    
    Problem: Valid SETATTR entries are missing in changelog when more
             than one metadata operation happen on same inode within
             changelog roll-over time.
    
    Cause: Metadata entries with fop num being GF_FOP_NULL are logged
           in changelog which is of no use. Since slice version
           checking is done for metadata entries to avoid logging of
           subsequent entries of same inode falling into same
           changelog, if the entry with GF_FOP_NULL is logged first,
           subsequent valid ones will be missed.
    
    Solution: Have a boundary condition to log only those fops whose fop
              number falls between GF_FOP_NULL and GF_FOP_MAXVALUE.
    
    BUG: 1159213
    Change-Id: I128cad323afba7d33f48df1ee5e78cb829536211
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/8964
    Reviewed-by: Aravinda VK <avishwan>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/9028

Comment 6 Anand Avati 2014-11-14 09:53:19 UTC
COMMIT: http://review.gluster.org/9083 committed in release-3.6 by Venky Shankar (vshankar) 
------
commit 7fd6c51d7595e433f25859394d13d161d8884c9e
Author: Kotresh HR <khiremat>
Date:   Wed Nov 5 12:36:32 2014 +0530

    feature/gfid-access: Always send setattr down in overloaded setxattr.
    
    Problem: File ownership is not being preserved for root in geo-rep
             mountbroker setup.
    
    Analysis and Cause:
             Entry creations for geo-rep is overloaded in ga_setxattr.
             It happens in two phase, entry creation followed by setattr
             to preserve ownership as in master.
    
             If uid and gid of file being synced is root, setattr was
             not being sent down. Since, the file creation happens with
             non-root user in mountborker geo-rep setup, if setattr is
             not done explicitly, file ownership is not preserved for root.
    
    Solution:
             Always pass setattr down in overloaded ga_setxattr.
    
    BUG: 1159213
    Change-Id: I0a6ef16333190b069e2ae326721d2b983f6a1a44
    Reviewed-on: http://review.gluster.org/9051
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/9083
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 7 Aravinda VK 2015-05-18 10:47:13 UTC
This bug is getting closed because a release has been made available that
should address the reported issue. In case the problem is still not fixed with
glusterfs-3.7.0, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.