Bug 1109601
| Summary: | dkms remove --no-initrd should only call /sbin/weak-modules with parameter --no-initramfs | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rudd-O DragonFear <rudd-o> | ||||||
| Component: | dkms | Assignee: | Simone Caronni <negativo17> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 20 | CC: | charles_rose, mario_limonciello, negativo17, rudd-o, tcallawa | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | dkms-2.2.0.3-25.fc19 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-07-26 16:00:23 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Rudd-O DragonFear
2014-06-15 20:19:32 UTC
Created attachment 909064 [details]
Add --no-initramfs to weak-modules command
Could you explain a bit better what is the problem you're facing? I'm not sure I understood. A "period" between the old and the new DKMS module package is usually the same RPM transaction, so why it should be unbootable? thanks, --Simone The patch you posted is not correct. It should execute the child process with the --no-initramfs parameter, ONLY when the dkms command has been invoked with the --no-initrd option. That period of time we are discussing, is up to ten minutes between the execution of the dkms initrd reconstruction for one RPM install (spl-dkms) and the execution of another dkms initrd reconstruction for the next RPM install (zfs-dkms). That is a ten minute window during which, if the system is rebooted accidentally, it has an invalid and unbootable initramfs. I would know, cos it happened to me. But ultimately the problem is a matter of principle -- if I invoke dkms with --no-initrd, I EXPECT it to not destroy my existing initrds as PROMISED by the --help option... and I also EXPECT it not to waste time (quite lengthy, within say a fully virtualized VM) rebuilding the initrd that I did NOT want to have rebuilt. Created attachment 909633 [details]
Add --no-initramfs to weak-modules command
Update for conditional
Ok, understood. What about this patch? I need to adjust it for EPEL 5, as RHEL 5's weak-modules has --no-initrd as parameter. Ugly, but hey, dkms and all of its "if" are not pretty either. If you have a better approach please let me know. That looks perfect. Push it. dkms-2.2.0.3-25.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/dkms-2.2.0.3-25.el6 dkms-2.2.0.3-25.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/dkms-2.2.0.3-25.el5 dkms-2.2.0.3-25.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dkms-2.2.0.3-25.fc20 dkms-2.2.0.3-25.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/dkms-2.2.0.3-25.fc19 Package dkms-2.2.0.3-25.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing dkms-2.2.0.3-25.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-2008/dkms-2.2.0.3-25.el6 then log in and leave karma (feedback). dkms-2.2.0.3-25.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. dkms-2.2.0.3-25.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. dkms-2.2.0.3-25.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. dkms-2.2.0.3-25.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |