Bug 1109689

Summary:	[SNAPSHOT]: once we reach the soft-limit and auto-delete is set to disable than we warn user which is not logged into the logs
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Rahul Hinduja <rhinduja>
Component:	snapshot	Assignee:	Nagaprasad Sathyanarayana <nsathyan>
Status:	CLOSED ERRATA	QA Contact:	Anil Shah <ashah>
Severity:	low	Docs Contact:
Priority:	medium
Version:	rhgs-3.0	CC:	asengupt, ashah, asrivast, mzywusko, nsathyan, rhs-bugs, rjoseph, senaik, smohan, storage-qa-internal, vagarwal
Target Milestone:	---
Target Release:	RHGS 3.1.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	SNAPSHOT
Fixed In Version:	glusterfs-3.7.0-3.el6rhs	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1112085 (view as bug list)		Environment:
Last Closed:	2015-07-29 04:32:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1112085, 1202842, 1223636

Description Rahul Hinduja 2014-06-16 07:18:45 UTC

Description of problem:
=======================

In a scenario where auto-delete is set to disable and snapshot creation reaches to its snap-max-soft-limit, with subsequent snapshot creation we create a snap and put a warning as follows:

[root@snapshot13 ~]# gluster snapshot create snap27 vol0
snapshot create: success: Snap snap27 created successfully
Warning: Soft-limit of volume (vol0) is reached. Snapshot creation is not possible once hard-limit is reached.
[root@snapshot13 ~]# 

The warning ideally should also be logged into the log messages which is not logging currently

Current log messages, upon reaching the snap-max-soft-limit and subsequent creation:

[2014-06-16 07:05:37.829227] I [rpc-clnt.c:969:rpc_clnt_connection_init] 0-management: setting frame-timeout to 600
[2014-06-16 07:05:37.855601] I [socket.c:2246:socket_event_handler] 0-transport: disconnecting now
[2014-06-16 07:05:37.859493] I [MSGID: 106005] [glusterd-handler.c:4131:__glusterd_brick_rpc_notify] 0-management: Brick snapshot13.lab.eng.blr.redhat.com:/var/run/gluster/snaps/efc6f36c7aba45fc80f84b419d4750fc/brick1/b0 has disconnected from glusterd.
[2014-06-16 07:05:37.860113] W [glusterd-utils.c:1558:glusterd_snap_volinfo_find] 0-management: Snap volume efc6f36c7aba45fc80f84b419d4750fc.snapshot13.lab.eng.blr.redhat.com.var-run-gluster-snaps-efc6f36c7aba45fc80f84b419d4750fc-brick1-b0 not found
[2014-06-16 07:05:38.009084] I [glusterd-pmap.c:227:pmap_registry_bind] 0-pmap: adding brick /var/run/gluster/snaps/efc6f36c7aba45fc80f84b419d4750fc/brick1/b0 on port 49183




Version-Release number of selected component (if applicable):
=============================================================

glusterfs-3.6.0.17-1.el6rhs.x86_64


How reproducible:
=================
1/1


Steps to Reproduce:
===================
1. Set the auto-delete to disable
2. Start creating snapshot until it reaches snap-max-soft-limit
3. Create another snapshot, which is successful and warning should be logged successfully on the console

Actual results:
===============

Snapshot creation is successful and warning is logged on console, but it didn't log any warning in the logs.

Expected results:
=================
Snapshot creation is successful and warning is logged on console, it should also log warning in the logs.

Comment 1 Sachin Pandit 2014-06-23 06:58:31 UTC

http://review.gluster.org/#/c/8147/ is posted upstream.

Comment 2 Sachin Pandit 2014-06-27 09:30:25 UTC

http://review.gluster.org/#/c/8147/ got merged upstream.

Comment 5 Anil Shah 2015-06-11 11:59:23 UTC

The message "W [MSGID: 106112] [glusterd-snapshot-utils.c:3535:glusterd_is_snap_soft_limit_reached] 0-management: Soft-limit (value = 5) of volume snapvol is reached. Snapshot creation is not possible once effective hard-limit (value = 10) is reached." repeated 2 times between [2015-06-11 11:54:55.360984] and [2015-06-11 11:55:41.869258]


[root@knightandday ~]# gluster snapshot config

Snapshot System Configuration:
snap-max-hard-limit : 256
snap-max-soft-limit : 50%
auto-delete : disable
activate-on-create : disable

Snapshot Volume Configuration:

Volume : snapvol
snap-max-hard-limit : 10
Effective snap-max-hard-limit : 10
Effective snap-max-soft-limit : 5 (50%)

Bug verified on build glusterfs-libs-3.7.1-1.el6.

Comment 8 errata-xmlrpc 2015-07-29 04:32:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1495.html