Bug 1112085 - [SNAPSHOT]: once we reach the soft-limit and auto-delete is set to disable than we warn user which is not logged into the logs
Summary: [SNAPSHOT]: once we reach the soft-limit and auto-delete is set to disable th...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Sachin Pandit
QA Contact:
URL:
Whiteboard: SNAPSHOT
Depends On: 1109689
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-23 06:45 UTC by Sachin Pandit
Modified: 2014-11-11 08:35 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1109689
Environment:
Last Closed: 2014-11-11 08:35:50 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sachin Pandit 2014-06-23 06:45:52 UTC
+++ This bug was initially created as a clone of Bug #1109689 +++

Description of problem:
=======================

In a scenario where auto-delete is set to disable and snapshot creation reaches to its snap-max-soft-limit, with subsequent snapshot creation we create a snap and put a warning as follows:

[root@snapshot13 ~]# gluster snapshot create snap27 vol0
snapshot create: success: Snap snap27 created successfully
Warning: Soft-limit of volume (vol0) is reached. Snapshot creation is not possible once hard-limit is reached.
[root@snapshot13 ~]# 

The warning ideally should also be logged into the log messages which is not logging currently

Current log messages, upon reaching the snap-max-soft-limit and subsequent creation:

[2014-06-16 07:05:37.829227] I [rpc-clnt.c:969:rpc_clnt_connection_init] 0-management: setting frame-timeout to 600
[2014-06-16 07:05:37.855601] I [socket.c:2246:socket_event_handler] 0-transport: disconnecting now
[2014-06-16 07:05:37.859493] I [MSGID: 106005] [glusterd-handler.c:4131:__glusterd_brick_rpc_notify] 0-management: Brick snapshot13.lab.eng.blr.redhat.com:/var/run/gluster/snaps/efc6f36c7aba45fc80f84b419d4750fc/brick1/b0 has disconnected from glusterd.
[2014-06-16 07:05:37.860113] W [glusterd-utils.c:1558:glusterd_snap_volinfo_find] 0-management: Snap volume efc6f36c7aba45fc80f84b419d4750fc.snapshot13.lab.eng.blr.redhat.com.var-run-gluster-snaps-efc6f36c7aba45fc80f84b419d4750fc-brick1-b0 not found
[2014-06-16 07:05:38.009084] I [glusterd-pmap.c:227:pmap_registry_bind] 0-pmap: adding brick /var/run/gluster/snaps/efc6f36c7aba45fc80f84b419d4750fc/brick1/b0 on port 49183




Version-Release number of selected component (if applicable):
=============================================================

glusterfs-3.6.0.17-1.el6rhs.x86_64


How reproducible:
=================
1/1


Steps to Reproduce:
===================
1. Set the auto-delete to disable
2. Start creating snapshot until it reaches snap-max-soft-limit
3. Create another snapshot, which is successful and warning should be logged successfully on the console

Actual results:
===============

Snapshot creation is successful and warning is logged on console, but it didn't log any warning in the logs.

Expected results:
=================
Snapshot creation is successful and warning is logged on console, it should also log warning in the logs.

Comment 1 Anand Avati 2014-06-23 06:46:39 UTC
REVIEW: http://review.gluster.org/8147 (glusterd/snapshot : Logging the soft-limit reach warning and hard-limit failure.) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-06-23 06:47:00 UTC
REVIEW: http://review.gluster.org/8147 (glusterd/snapshot : Logging the soft-limit reach warning and hard-limit reach failure.) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-06-23 09:32:21 UTC
REVIEW: http://review.gluster.org/8147 (glusterd/snapshot : Logging the soft-limit reach warning and hard-limit failure.) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-06-24 05:32:08 UTC
REVIEW: http://review.gluster.org/8147 (glusterd/snapshot : Logging the soft-limit reach warning and hard-limit failure.) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-06-27 07:21:34 UTC
COMMIT: http://review.gluster.org/8147 committed in master by Kaushal M (kaushal) 
------
commit fc1ae37ea4c353286f9a6f3d3e95041feee6ac7d
Author: Sachin Pandit <spandit>
Date:   Mon Jun 23 05:11:11 2014 +0530

    glusterd/snapshot : Logging the soft-limit reach warning and
    hard-limit failure.
    
    Change-Id: I5083d30c04c784b7f134b8a919b84c225c25f806
    BUG: 1112085
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8147
    Reviewed-by: Prashanth Pai <ppai>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Kaushal M <kaushal>

Comment 6 Niels de Vos 2014-09-22 12:43:40 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-11-11 08:35:50 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.