Bug 1110662

Summary:	[upgrade/async-tasks] 'Plugin' object has no attribute 'queryBoolean'
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	rhev-integ
Component:	ovirt-engine-setup	Assignee:	Sandro Bonazzola <sbonazzo>
Status:	CLOSED ERRATA	QA Contact:	Petr Beňas <pbenas>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.3.0	CC:	acathrow, bazulay, didi, gklein, iheim, lveyde, pstehlik, Rhev-m-bugs, rnori, sbonazzo, sherold, stirabos, tpoitras, yeylon
Target Milestone:	---	Keywords:	ZStream
Target Release:	3.4.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	integration
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	During setup/upgrade, fixed failures while prompting the user whether to stop async tasks or to fix database inconsistencies.	Story Points:	---
Clone Of:	1110510	Environment:
Last Closed:	2014-07-29 16:24:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1110510
Bug Blocks:

Comment 2 Yedidyah Bar David 2014-07-07 06:27:17 UTC

Timothy, just to give a bit more details:

dialog.queryBoolean is a function to ask the user a Yes/No question.

There were two places that called instead a non-existent self.dialog.queryBoolean. This caused an error message if the execution reached these places in the code.

These two places were:
1. Code checking for existing async tasks (and similar).
2. Code checking for database inconsistencies.

If such were found during setup (upgrade), user is prompted asking whether to try and fix (or abort setup).

So a potential doc text might be something like:

During setup/upgrade, fixed failures while prompting the user whether to stop async tasks or to fix database inconsistencies.

Comment 3 Petr Beňas 2014-07-14 16:47:40 UTC

I've tried upgrading from 3.3 to 3.4 (rhevm-setup-3.4.1-0.25.el6ev) with engine stopped in the middle of template creation. The upgrade succeeded, there is no error about missing queryBoolean attribute in the setup log, but the template creation task seems to be stuck and the VM disk locked. Should I consider this as a problem of this patch or a separate issue?

Comment 4 Sandro Bonazzola 2014-07-15 07:27:09 UTC

(In reply to Petr Beňas from comment #3)
> I've tried upgrading from 3.3 to 3.4 (rhevm-setup-3.4.1-0.25.el6ev) with
> engine stopped in the middle of template creation. The upgrade succeeded,
> there is no error about missing queryBoolean attribute in the setup log, but
> the template creation task seems to be stuck and the VM disk locked. Should
> I consider this as a problem of this patch or a separate issue?

I think this is a separate issue.

Comment 5 Petr Beňas 2014-07-15 08:01:18 UTC

OK, setting Verified then.

Comment 7 errata-xmlrpc 2014-07-29 16:24:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0960.html