Bug 1110662 - [upgrade/async-tasks] 'Plugin' object has no attribute 'queryBoolean'
Summary: [upgrade/async-tasks] 'Plugin' object has no attribute 'queryBoolean'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-setup
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.4.1
Assignee: Sandro Bonazzola
QA Contact: Petr Beňas
URL:
Whiteboard: integration
Depends On: 1110510
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-18 08:17 UTC by rhev-integ
Modified: 2014-07-29 16:24 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
During setup/upgrade, fixed failures while prompting the user whether to stop async tasks or to fix database inconsistencies.
Clone Of: 1110510
Environment:
Last Closed: 2014-07-29 16:24:18 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:0960 0 normal SHIPPED_LIVE Red Hat Enterprise Virtualization Manager 3.4.1 2014-07-29 20:23:10 UTC
oVirt gerrit 28874 0 master MERGED packaging: setup: fix references to dialog.queryBoolean Never
oVirt gerrit 28878 0 ovirt-engine-3.4 MERGED packaging: setup: fix references to dialog.queryBoolean Never

Comment 2 Yedidyah Bar David 2014-07-07 06:27:17 UTC
Timothy, just to give a bit more details:

dialog.queryBoolean is a function to ask the user a Yes/No question.

There were two places that called instead a non-existent self.dialog.queryBoolean. This caused an error message if the execution reached these places in the code.

These two places were:
1. Code checking for existing async tasks (and similar).
2. Code checking for database inconsistencies.

If such were found during setup (upgrade), user is prompted asking whether to try and fix (or abort setup).

So a potential doc text might be something like:

During setup/upgrade, fixed failures while prompting the user whether to stop async tasks or to fix database inconsistencies.

Comment 3 Petr Beňas 2014-07-14 16:47:40 UTC
I've tried upgrading from 3.3 to 3.4 (rhevm-setup-3.4.1-0.25.el6ev) with engine stopped in the middle of template creation. The upgrade succeeded, there is no error about missing queryBoolean attribute in the setup log, but the template creation task seems to be stuck and the VM disk locked. Should I consider this as a problem of this patch or a separate issue?

Comment 4 Sandro Bonazzola 2014-07-15 07:27:09 UTC
(In reply to Petr Beňas from comment #3)
> I've tried upgrading from 3.3 to 3.4 (rhevm-setup-3.4.1-0.25.el6ev) with
> engine stopped in the middle of template creation. The upgrade succeeded,
> there is no error about missing queryBoolean attribute in the setup log, but
> the template creation task seems to be stuck and the VM disk locked. Should
> I consider this as a problem of this patch or a separate issue?

I think this is a separate issue.

Comment 5 Petr Beňas 2014-07-15 08:01:18 UTC
OK, setting Verified then.

Comment 7 errata-xmlrpc 2014-07-29 16:24:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0960.html


Note You need to log in before you can comment on or make changes to this bug.