Bug 1111196
| Summary: | Review Request: perl-App-find2perl - Translate find command lines to Perl code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | David Dick <ddick> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ddick, package-review |
| Target Milestone: | --- | Flags: | ddick:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-App-find2perl-1.003-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-25 12:27:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Pisar
2014-06-19 12:49:11 UTC
The files were sub-packaged from perl.spec in perl-5.18.2-300.fc21. Should this package have a subpackage of "find2perl"? Since the following are the only installed files for this package; /usr/bin/find2perl /usr/share/doc/perl-App-find2perl /usr/share/doc/perl-App-find2perl/Changes /usr/share/doc/perl-App-find2perl/LICENSE /usr/share/doc/perl-App-find2perl/README /usr/share/man/man1/find2perl.1.gz it might be easier for users to "yum install find2perl" rather than "yum install perl-App-find2perl"? (In reply to David Dick from comment #2) > Should this package have a subpackage of "find2perl"? > > Since the following are the only installed files for this package; > > /usr/bin/find2perl > /usr/share/doc/perl-App-find2perl > /usr/share/doc/perl-App-find2perl/Changes > /usr/share/doc/perl-App-find2perl/LICENSE > /usr/share/doc/perl-App-find2perl/README > /usr/share/man/man1/find2perl.1.gz > > it might be easier for users to "yum install find2perl" rather than "yum > install perl-App-find2perl"? In the past it's not. But I think we could add "Provides: find2perl" after the split. The Fedora policy is to stick to upstream name. Upstream name is App-find2perl. I don't see much positive points in providing find2perl while the package provides /usr/bin/find2perl. I haven't seen coreutils providing cp or mv. Although I understand your arguments, I think it would just bring yet another dilemma and inconsistencies which tool name to provide explicitly and which not. BTW when was the last time you used find2perl? I believe the tool is as forgotten as Perl 5 porters expunged it from the Perl core. (In reply to Petr Pisar from comment #4) > Although I understand your arguments, I think it would just bring yet > another dilemma and inconsistencies which tool name to provide explicitly > and which not. no problems, was just wondering. License is correct. Build and RunTime Requires are good. Package builds ok at http://koji.fedoraproject.org/koji/taskinfo?taskID=7074610 rpmlint is clean. Approved. New Package SCM Request ======================= Package Name: perl-App-find2perl Short Description: Translate find command lines to Perl code Upstream URL: http://search.cpan.org/dist/App-find2perl/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. |