Bug 1111196 - Review Request: perl-App-find2perl - Translate find command lines to Perl code
Summary: Review Request: perl-App-find2perl - Translate find command lines to Perl code
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-19 12:49 UTC by Petr Pisar
Modified: 2014-06-25 12:27 UTC (History)
2 users (show)

Fixed In Version: perl-App-find2perl-1.003-1.fc21
Clone Of:
Environment:
Last Closed: 2014-06-25 12:27:07 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2014-06-19 12:49:11 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-App-find2perl/perl-App-find2perl.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-App-find2perl/perl-App-find2perl-1.003-1.fc21.src.rpm
Description:
This package delivers find2perl tool which is a little translator to convert
find command lines to equivalent Perl code.

Fedora Account System Username: ppisar

---
This package will dual-live with perl.spec's sub-package (after it will be sub-packaged).

Comment 1 Petr Pisar 2014-06-20 09:26:03 UTC
The files were sub-packaged from perl.spec in perl-5.18.2-300.fc21.

Comment 2 David Dick 2014-06-22 04:58:16 UTC
Should this package have a subpackage of "find2perl"?

Since the following are the only installed files for this package;

/usr/bin/find2perl
/usr/share/doc/perl-App-find2perl
/usr/share/doc/perl-App-find2perl/Changes
/usr/share/doc/perl-App-find2perl/LICENSE
/usr/share/doc/perl-App-find2perl/README
/usr/share/man/man1/find2perl.1.gz

it might be easier for users to "yum install find2perl" rather than "yum install perl-App-find2perl"?

Comment 3 Christopher Meng 2014-06-22 05:24:54 UTC
(In reply to David Dick from comment #2)
> Should this package have a subpackage of "find2perl"?
> 
> Since the following are the only installed files for this package;
> 
> /usr/bin/find2perl
> /usr/share/doc/perl-App-find2perl
> /usr/share/doc/perl-App-find2perl/Changes
> /usr/share/doc/perl-App-find2perl/LICENSE
> /usr/share/doc/perl-App-find2perl/README
> /usr/share/man/man1/find2perl.1.gz
> 
> it might be easier for users to "yum install find2perl" rather than "yum
> install perl-App-find2perl"?

In the past it's not. But I think we could add "Provides: find2perl" after the split.

Comment 4 Petr Pisar 2014-06-23 06:21:10 UTC
The Fedora policy is to stick to upstream name. Upstream name is App-find2perl.

I don't see much positive points in providing find2perl while the package provides /usr/bin/find2perl. I haven't seen coreutils providing cp or mv.

Although I understand your arguments, I think it would just bring yet another dilemma and inconsistencies which tool name to provide explicitly and which not.

BTW when was the last time you used find2perl? I believe the tool is as forgotten as Perl 5 porters expunged it from the Perl core.

Comment 5 David Dick 2014-06-23 08:29:35 UTC
(In reply to Petr Pisar from comment #4)
> Although I understand your arguments, I think it would just bring yet
> another dilemma and inconsistencies which tool name to provide explicitly
> and which not.

no problems, was just wondering.

Comment 6 David Dick 2014-06-25 11:08:31 UTC
License is correct.

Build and RunTime Requires are good.

Package builds ok at http://koji.fedoraproject.org/koji/taskinfo?taskID=7074610

rpmlint is clean.

Approved.

Comment 7 Petr Pisar 2014-06-25 11:14:11 UTC
New Package SCM Request
=======================
Package Name: perl-App-find2perl
Short Description: Translate find command lines to Perl code
Upstream URL: http://search.cpan.org/dist/App-find2perl/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 8 Gwyn Ciesla 2014-06-25 11:36:30 UTC
Git done (by process-git-requests).

Comment 9 Petr Pisar 2014-06-25 12:27:07 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.