Bug 1111692

Summary:	Review Request: purple-whatsapp - Libpurple plug-in for Pidgin and others, supporting WhatsApp protocol
Product:	[Fedora] Fedora	Reporter:	Robert Scheck <redhat-bugzilla>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, volker27
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-01 19:58:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert Scheck 2014-06-20 18:20:09 UTC

Spec URL: http://labs.linuxnetz.de/bugzilla/purple-whatsapp.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/purple-whatsapp-0.4-1.20140413git.src.rpm
Description: This is a WhatsApp plugin for Pidgin and libpurple messengers.
It connects to the WhatsApp servers using the password (which needs to be 
retrieved separately). Only one client can connect at a time (including your 
phone).
Fedora Account System Username: robert

Comment 1 Volker Fröhlich 2014-06-20 20:22:38 UTC

You don't need a buildroot definition, a clean section and the initial rm in the install section. Neither do you need defattr.

Why are you calling the package purple-whatsapp when the tarball is called whatsapp-purple?

The version constraint for libpurple is not necessary, as it is fulfilled in any version of Fedora.

The author should provide a license file to include.

Comment 2 Robert Scheck 2014-06-20 20:42:51 UTC

(In reply to Volker Fröhlich from comment #1)
> You don't need a buildroot definition, a clean section and the initial rm in
> the install section. Neither do you need defattr.

Because of Fedora EPEL 5.

> Why are you calling the package purple-whatsapp when the tarball is called
> whatsapp-purple?

Because all other packages in Fedora seem to be named purple-<ext> independent
of the upstream tarball name.

> The version constraint for libpurple is not necessary, as it is fulfilled in
> any version of Fedora.

That is right, but it doesn't hurt as well IMHO.

> The author should provide a license file to include.

Good point, inform upstream about that.

Comment 3 Volker Fröhlich 2014-06-20 21:18:28 UTC

> Because of Fedora EPEL 5.

Ah, OK, I didn't expect that. The defattr is not necessary there though.

Comment 4 Jason Taylor 2014-06-21 00:28:22 UTC

Just a side note about the Source0, you may want to check out http://fedoraproject.org/wiki/Packaging:SourceURL. If the source is via github (which it appears to be) there are some additional %global.

Comment 5 Robert Scheck 2017-10-01 19:58:40 UTC

As per https://github.com/davidgfnet/whatsapp-purple the software is no
longer maintained.