Bug 1111692 - Review Request: purple-whatsapp - Libpurple plug-in for Pidgin and others, supporting WhatsApp protocol
Summary: Review Request: purple-whatsapp - Libpurple plug-in for Pidgin and others, su...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-20 18:20 UTC by Robert Scheck
Modified: 2017-10-01 19:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-01 19:58:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Robert Scheck 2014-06-20 18:20:09 UTC
Spec URL: http://labs.linuxnetz.de/bugzilla/purple-whatsapp.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/purple-whatsapp-0.4-1.20140413git.src.rpm
Description: This is a WhatsApp plugin for Pidgin and libpurple messengers.
It connects to the WhatsApp servers using the password (which needs to be 
retrieved separately). Only one client can connect at a time (including your 
phone).
Fedora Account System Username: robert

Comment 1 Volker Fröhlich 2014-06-20 20:22:38 UTC
You don't need a buildroot definition, a clean section and the initial rm in the install section. Neither do you need defattr.

Why are you calling the package purple-whatsapp when the tarball is called whatsapp-purple?

The version constraint for libpurple is not necessary, as it is fulfilled in any version of Fedora.

The author should provide a license file to include.

Comment 2 Robert Scheck 2014-06-20 20:42:51 UTC
(In reply to Volker Fröhlich from comment #1)
> You don't need a buildroot definition, a clean section and the initial rm in
> the install section. Neither do you need defattr.

Because of Fedora EPEL 5.

> Why are you calling the package purple-whatsapp when the tarball is called
> whatsapp-purple?

Because all other packages in Fedora seem to be named purple-<ext> independent
of the upstream tarball name.

> The version constraint for libpurple is not necessary, as it is fulfilled in
> any version of Fedora.

That is right, but it doesn't hurt as well IMHO.

> The author should provide a license file to include.

Good point, inform upstream about that.

Comment 3 Volker Fröhlich 2014-06-20 21:18:28 UTC
> Because of Fedora EPEL 5.

Ah, OK, I didn't expect that. The defattr is not necessary there though.

Comment 4 Jason Taylor 2014-06-21 00:28:22 UTC
Just a side note about the Source0, you may want to check out http://fedoraproject.org/wiki/Packaging:SourceURL. If the source is via github (which it appears to be) there are some additional %global.

Comment 5 Robert Scheck 2017-10-01 19:58:40 UTC
As per https://github.com/davidgfnet/whatsapp-purple the software is no
longer maintained.


Note You need to log in before you can comment on or make changes to this bug.