Bug 1111981 (kf5-kdelibs4support)

Summary: Review Request: kf5-kdelibs4support - KDE Frameworks 5 Tier 4 module with porting aid from KDELibs 4
Product: [Fedora] Fedora Reporter: Daniel Vrátil <dvratil>
Component: Package ReviewAssignee: Jan Grulich <jgrulich>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jeischma, jgrulich, package-review
Target Milestone: ---Flags: jgrulich: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-07 14:56:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1108810, 1108812, 1108817, 1108824, 1108830, 1111948, 1111952    
Bug Blocks: 656997, 1086148    

Description Daniel Vrátil 2014-06-22 13:19:56 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdelibs4support.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdelibs4support-4.100.0-1.fc20.src.rpm
Description: This framework provides code and utilities to ease the transition from kdelibs 4 to KDE Frameworks 5. This includes CMake macros and C++ classes whose functionality has been replaced by code in CMake, Qt and other frameworks.
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2014-07-07 11:46:37 UTC
1) Missing BSD license
2) Source cannot be downloaded from the given URL
3) Files installed to /etc should have %config at the beginning of line

Comment 2 Daniel Vrátil 2014-07-07 12:42:49 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdelibs4support.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdelibs4support-4.100.0-2.fc20.src.rpm

- Fixed license
- Fixed Source0 URL
- Fixed installation of config files

Comment 3 Jan Grulich 2014-07-07 13:03:54 UTC
Looks good now, approved.

Comment 4 Daniel Vrátil 2014-07-07 13:05:30 UTC
New Package SCM Request
=======================
Package Name: kf5-kdelibs4support
Short Description: KDE Frameworks 5 Tier 4 module with porting aid from KDELibs 4
Upstream URL: http://www.kde.org
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2014-07-07 13:21:46 UTC
Git done (by process-git-requests).

Comment 6 Daniel Vrátil 2014-09-25 09:06:18 UTC
Package Change Request
=======================
Package Name: kf5-kdelibs4support
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than

Comment 7 Gwyn Ciesla 2014-09-25 13:16:07 UTC
Git done (by process-git-requests).