Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kwallet.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kwallet-4.100.0-1.fc20.src.rpm Description: KDE Frameworks 5 Tier 3 solution for password management Fedora Account System Username: dvratil
Issues: ======= - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in kf5-kwallet-libs See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries Full report below: --------------------------------------------------------------------------- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in kf5-kwallet-libs See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2)", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/ltinkl/tmp/1108830-kf5-kwallet/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5 -kwallet-libs , kf5-kwallet-runtime , kf5-kwallet-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: #%define snapshot 20140205, %define framework kwallet [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- No handlers could be found for logger "trace.__main__" INFO: mock.py version 1.1.39 starting... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Mock Version: 1.1.39 INFO: Mock Version: 1.1.39 Start: lock buildroot INFO: installing package(s): /home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-4.100.0-1.fc21.i686.rpm /home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-libs-4.100.0-1.fc21.i686.rpm /home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-runtime-4.100.0-1.fc21.i686.rpm /home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-devel-4.100.0-1.fc21.i686.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', '--releasever', '21', 'install', '/home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-4.100.0-1.fc21.i686.rpm', '/home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-libs-4.100.0-1.fc21.i686.rpm', '/home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-runtime-4.100.0-1.fc21.i686.rpm', '/home/ltinkl/tmp/1108830-kf5-kwallet/results/kf5-kwallet-devel-4.100.0-1.fc21.i686.rpm'] Error: Package: kf5-kwallet-runtime-4.100.0-1.fc21.i686 (/kf5-kwallet-runtime-4.100.0-1.fc21.i686) Requires: kf5-kded You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: kf5-kwallet-4.100.0-1.fc21.i686.rpm kf5-kwallet-libs-4.100.0-1.fc21.i686.rpm kf5-kwallet-runtime-4.100.0-1.fc21.i686.rpm kf5-kwallet-devel-4.100.0-1.fc21.i686.rpm kf5-kwallet-4.100.0-1.fc21.src.rpm kf5-kwallet.i686: E: no-binary kf5-kwallet-libs.i686: W: no-documentation kf5-kwallet-libs.i686: E: library-without-ldconfig-postin /usr/lib/libKF5Wallet.so.4.100.0 kf5-kwallet-libs.i686: E: library-without-ldconfig-postun /usr/lib/libKF5Wallet.so.4.100.0 kf5-kwallet-libs.i686: E: library-without-ldconfig-postin /usr/lib/libkwalletbackend5.so.4.100.0 kf5-kwallet-libs.i686: E: library-without-ldconfig-postun /usr/lib/libkwalletbackend5.so.4.100.0 kf5-kwallet-runtime.i686: W: spelling-error Summary(en_US) deamon -> daemon, demon, deacon kf5-kwallet-runtime.i686: W: spelling-error %description -l en_US deamon -> daemon, demon, deacon kf5-kwallet-runtime.i686: W: no-documentation kf5-kwallet-runtime.i686: W: no-manual-page-for-binary kwalletd5 kf5-kwallet-devel.i686: W: no-documentation kf5-kwallet.src: W: strange-permission kwallet-4.100.0.tar.xz 0666L kf5-kwallet.src:1: W: macro-in-comment %define kf5-kwallet.src:11: W: macro-in-comment %{framework} kf5-kwallet.src:11: W: macro-in-comment %{version} kf5-kwallet.src:12: W: macro-in-comment %{framework} kf5-kwallet.src:13: W: macro-in-comment %{name} kf5-kwallet.src:13: W: macro-in-comment %{version} kf5-kwallet.src:13: W: macro-in-comment %{snapshot} kf5-kwallet.src:14: W: macro-in-comment %{name} kf5-kwallet.src:14: W: macro-in-comment %{version} kf5-kwallet.src:14: W: macro-in-comment %{snapshot} 5 packages and 0 specfiles checked; 5 errors, 17 warnings. Requires -------- kf5-kwallet (rpmlib, GLIBC filtered): /sbin/ldconfig kf5-kwallet-libs(x86-32) kf5-kwallet-runtime(x86-32) kf5-kwallet-libs (rpmlib, GLIBC filtered): kf5-filesystem libKF5ConfigCore.so.5 libKF5CoreAddons.so.5 libKF5I18n.so.5 libKF5Notifications.so.5 libKF5WidgetsAddons.so.5 libKF5WindowSystem.so.5 libQt5Core.so.5 libQt5DBus.so.5 libQt5Gui.so.5 libQt5Widgets.so.5 libc.so.6 libgcc_s.so.1 libgcrypt.so.20 libgcrypt.so.20(GCRYPT_1.6) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) kf5-kwallet-runtime (rpmlib, GLIBC filtered): kf5-kded libKF5ConfigCore.so.5 libKF5CoreAddons.so.5 libKF5DBusAddons.so.5 libKF5I18n.so.5 libKF5IconThemes.so.5 libKF5Notifications.so.5 libKF5Service.so.5 libKF5Wallet.so.5 libKF5WidgetsAddons.so.5 libKF5WindowSystem.so.5 libQt5Core.so.5 libQt5DBus.so.5 libQt5Gui.so.5 libQt5Widgets.so.5 libc.so.6 libgcc_s.so.1 libgcrypt.so.20 libkwalletbackend5.so.5 libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) kf5-kwallet-devel (rpmlib, GLIBC filtered): kf5-kconfig-devel kf5-kcoreaddons-devel kf5-kdbusaddons-devel kf5-ki18n-devel kf5-kiconthemes-devel kf5-knotifications-devel kf5-kservice-devel kf5-kwallet-libs(x86-32) kf5-kwidgetsaddons-devel kf5-kwindowsystem-devel libKF5Wallet.so.5 libkwalletbackend5.so.5 Provides -------- kf5-kwallet: kf5-kwallet kf5-kwallet(x86-32) kf5-kwallet-libs: kf5-kwallet-libs kf5-kwallet-libs(x86-32) libKF5Wallet.so.5 libkwalletbackend5.so.5 kf5-kwallet-runtime: kf5-kwallet-runtime kf5-kwallet-runtime(x86-32) kf5-kwallet-devel: kf5-kwallet-devel kf5-kwallet-devel(x86-32) Source checksums ---------------- http://download.kde.org/unstable/frameworks/4.100.0/kwallet-4.100.0.tar.xz : CHECKSUM(SHA256) this package : b0a16c094e90824ee8b0d45cdf9027116d72c5b9b91377dda90eefeb53a3f5c0 CHECKSUM(SHA256) upstream package : b0a16c094e90824ee8b0d45cdf9027116d72c5b9b91377dda90eefeb53a3f5c0 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1108830 -m fedora-rawhide-i386 --local-repo /home/ltinkl/kf5-packages/ Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Built with local dependencies: /home/ltinkl/kf5-packages/kf5-knotifications-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kcmutils-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kxmlgui-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kservice-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kbookmarks-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-knotifications-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-ktextwidgets-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kiconthemes-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-ktextwidgets-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kxmlgui-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kservice-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kbookmarks-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kiconthemes-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kcmutils-4.100.0-1.fc21.i686.rpm
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kwallet.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kwallet-4.100.0-2.fc20.src.rpm Fixed the %post and %postun stuff and removed kf5-kded from Requires, as it would create circular dependency.
OK, good to go
New Package SCM Request ======================= Package Name: kf5-kwallet Short Description: KDE Frameworks 5 Tier 3 solution for password management Upstream URL: http://www.kde.org Owners: dvratil ltinkl jgrulich kkofler rdieter than Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: kf5-kwallet New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than