Bug 1112410
| Summary: | fedora-review thinks %%clean == %clean | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | leamas.alec, pingou, sochotni |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-17 10:32:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Dirty fix in https://fedorahosted.org/FedoraReview/changeset/db1a23b70d5f7 We don't really parse the spec, this is just regexes. Overall, this means a lot of corner cases like this one while still being "good enough". |
Description of problem: A package under review that includes a mention of a (now gone) %clean section in the changelog had this warning generated: Generic: [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required The actual changelog entry mentions %%clean, but fedora-review seems to ignore the double % sign, as well as the fact that the string in question appears in the %changelog section. Version-Release number of selected component (if applicable): fedora-review-0.5.1-2.fc20.noarch How reproducible: Always Steps to Reproduce: 1. Run fedora-review on the package in bug 1102950 2. 3. Actual results: fedora-review complains about a nonexistent %clean section Expected results: No such complaint, since there is no %clean section Additional info: