Fedora Account System
Red Hat Associate
Red Hat Customer
Description of problem: A package under review that includes a mention of a (now gone) %clean section in the changelog had this warning generated: Generic: [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required The actual changelog entry mentions %%clean, but fedora-review seems to ignore the double % sign, as well as the fact that the string in question appears in the %changelog section. Version-Release number of selected component (if applicable): fedora-review-0.5.1-2.fc20.noarch How reproducible: Always Steps to Reproduce: 1. Run fedora-review on the package in bug 1102950 2. 3. Actual results: fedora-review complains about a nonexistent %clean section Expected results: No such complaint, since there is no %clean section Additional info:
Dirty fix in https://fedorahosted.org/FedoraReview/changeset/db1a23b70d5f7 We don't really parse the spec, this is just regexes. Overall, this means a lot of corner cases like this one while still being "good enough".