Bug 1112629

Summary:	Typo in kwargs "removable" for USB Storage
Product:	[Community] Virtualization Tools	Reporter:	snoopyf
Component:	virt-manager	Assignee:	Giuseppe Scrivano <gscrivan>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, berrange, crobinso, gscrivan, snoopyf
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-24 15:19:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description snoopyf 2014-06-24 10:59:45 UTC

Description of problem:
When marking an USB Storage "Removable" in virt-manaer and try to save it afterwards an error appears saying that option "removeable" is not valid.

Version-Release number of selected component (if applicable):
virt-manager 1.0.1

How reproducible:
Add USB Storage, set it removable, save

Actual results:
Error Message

Expected results:
set "removable='on'" in target tag of XML

Additional info:
Solution:
Fix typo in virtManager/details.py, Line ~ 2095:
- kwargs["removeable"] = bool(
+ kwargs["removable"] = bool(

Comment 1 Giuseppe Scrivano 2014-06-24 12:07:08 UTC

I've reassigned it to me as I was already working on upstream virt-manager.

Prepared a patch here:
https://www.redhat.com/archives/virt-tools-list/2014-June/msg00219.html

Comment 2 Giuseppe Scrivano 2014-06-24 15:19:25 UTC

fixed upstream by:

commit eb5b2613110dfaa23626a16704d18df0dbba5086
Author: Giuseppe Scrivano <gscrivan>
Date:   Tue Jun 24 13:59:12 2014 +0200

    details.py: fix typo
    
    s|removeable|removable|
    
    Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112629
    
    Signed-off-by: Giuseppe Scrivano <gscrivan>