Bug 1112629 - Typo in kwargs "removable" for USB Storage
Summary: Typo in kwargs "removable" for USB Storage
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Giuseppe Scrivano
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-24 10:59 UTC by snoopyf
Modified: 2014-06-24 15:19 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-24 15:19:25 UTC
Embargoed:

Attachments (Terms of Use)

Description snoopyf 2014-06-24 10:59:45 UTC 
Description of problem:
When marking an USB Storage "Removable" in virt-manaer and try to save it afterwards an error appears saying that option "removeable" is not valid.

Version-Release number of selected component (if applicable):
virt-manager 1.0.1

How reproducible:
Add USB Storage, set it removable, save

Actual results:
Error Message

Expected results:
set "removable='on'" in target tag of XML

Additional info:
Solution:
Fix typo in virtManager/details.py, Line ~ 2095:
- kwargs["removeable"] = bool(
+ kwargs["removable"] = bool(
Comment 1 Giuseppe Scrivano 2014-06-24 12:07:08 UTC 
I've reassigned it to me as I was already working on upstream virt-manager.

Prepared a patch here:
https://www.redhat.com/archives/virt-tools-list/2014-June/msg00219.html
Comment 2 Giuseppe Scrivano 2014-06-24 15:19:25 UTC 
fixed upstream by:

commit eb5b2613110dfaa23626a16704d18df0dbba5086
Author: Giuseppe Scrivano <gscrivan>
Date:   Tue Jun 24 13:59:12 2014 +0200

    details.py: fix typo
    
    s|removeable|removable|
    
    Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112629
    
    Signed-off-by: Giuseppe Scrivano <gscrivan>
Note You need to log in before you can comment on or make changes to this bug.