Bug 1113155

Summary:	[setup] setup contains d/s values for guest tools
Product:	[oVirt] ovirt-engine	Reporter:	Jiri Belka <jbelka>
Component:	Setup.Engine	Assignee:	Lev Veyde <lveyde>
Status:	CLOSED NOTABUG	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	---	CC:	bugs, bzrh.bobd, gklein, rbalakri, sbonazzo, yeylon, ylavi
Target Milestone:	ovirt-3.6.0-rc	Flags:	ylavi: ovirt-3.6.0? ylavi: planning_ack? ylavi: devel_ack? ylavi: testing_ack?
Target Release:	3.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	integration
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-09-22 11:23:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1113433

Description Jiri Belka 2014-06-25 14:09:45 UTC

Description of problem:
While checking for auto-uploading guest tools iso/vfd to local ISO domain, I discovered there are hardcoded d/s strings for guest tools:

# egrep -IRi "rhev(-|_)" /usr/share/ovirt-engine/setup
/usr/share/ovirt-engine/setup/ovirt_engine_setup/constants.py:    RHEV_GUEST_TOOLS_DIR = os.path.join(
/usr/share/ovirt-engine/setup/ovirt_engine_setup/constants.py:        'rhev-guest-tools-iso',

plus alonbl@ adds:

16:02 < alonbl> jbelka: it is since ever!
16:02 < alonbl> see: packaging/fedora/setup/basedefs.py:FILE_RHEV_GUEST_TOOLS_ISO="/usr/share/rhev-guest-tools-iso/rhev-tools-setup.iso"

/* Not sure if auto-uploading works on ovirt */

Version-Release number of selected component (if applicable):
ovirt-engine-setup-base-3.5.0-0.0.master.20140605145557.git3ddd2de.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. use grep cmd above
2.
3.

Actual results:
d/s penetrates ovirt

Expected results:
:)

Additional info:
see alonbl@ comment and repair also packaging stuff

Comment 1 Jiri Belka 2014-06-25 14:14:00 UTC

Other d/s strings:

/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py:        'REMOTE_PATH': 'no.one.reads.this:/rhev',

Comment 2 Sandro Bonazzola 2015-02-23 14:27:40 UTC

Not critical, not a regression, not urgent. Postponed to 3.6.

Comment 3 Lev Veyde 2015-09-20 15:56:38 UTC

I don't think that there is any issue with that.

The code right now is unified u/s to support both u/s and d/s guest tools auto uploading.

In theory we can remove the code to upload the d/s tools and move it into separate d/s only patches, but there is really no value to that, and these will require additional maintenance as.

I suggest to close this as not a bug.

Comment 4 Sandro Bonazzola 2015-09-22 11:23:26 UTC

(In reply to Lev Veyde from comment #3)
> I suggest to close this as not a bug.

I agree. Closing.