Description of problem: While checking for auto-uploading guest tools iso/vfd to local ISO domain, I discovered there are hardcoded d/s strings for guest tools: # egrep -IRi "rhev(-|_)" /usr/share/ovirt-engine/setup /usr/share/ovirt-engine/setup/ovirt_engine_setup/constants.py: RHEV_GUEST_TOOLS_DIR = os.path.join( /usr/share/ovirt-engine/setup/ovirt_engine_setup/constants.py: 'rhev-guest-tools-iso', plus alonbl@ adds: 16:02 < alonbl> jbelka: it is since ever! 16:02 < alonbl> see: packaging/fedora/setup/basedefs.py:FILE_RHEV_GUEST_TOOLS_ISO="/usr/share/rhev-guest-tools-iso/rhev-tools-setup.iso" /* Not sure if auto-uploading works on ovirt */ Version-Release number of selected component (if applicable): ovirt-engine-setup-base-3.5.0-0.0.master.20140605145557.git3ddd2de.el6.noarch How reproducible: 100% Steps to Reproduce: 1. use grep cmd above 2. 3. Actual results: d/s penetrates ovirt Expected results: :) Additional info: see alonbl@ comment and repair also packaging stuff
Other d/s strings: /usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py: 'REMOTE_PATH': 'no.one.reads.this:/rhev',
Not critical, not a regression, not urgent. Postponed to 3.6.
I don't think that there is any issue with that. The code right now is unified u/s to support both u/s and d/s guest tools auto uploading. In theory we can remove the code to upload the d/s tools and move it into separate d/s only patches, but there is really no value to that, and these will require additional maintenance as. I suggest to close this as not a bug.
(In reply to Lev Veyde from comment #3) > I suggest to close this as not a bug. I agree. Closing.