Bug 1113440

Summary: [packaging] package ovirt-guest-tools-iso as rpm
Product: [Retired] oVirt Reporter: Jiri Belka <jbelka>
Component: ovirt-engine-installerAssignee: Lev Veyde <lveyde>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: medium Docs Contact:
Priority: high    
Version: 3.5CC: bugs, bzrh.bobd, didi, gklein, iheim, lveyde, rbalakri, sbonazzo, stirabos, yeylon
Target Milestone: ---   
Target Release: 3.5.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-21 16:04:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1108789    

Description Jiri Belka 2014-06-26 08:21:49 UTC
Description of problem:
package ovirt-guest-tools-iso and virtio-win as rpms and make it deps of ovirt-engine, otherwise there would be no possibility for engine-setup to auto-populate local iso domain with guest tools iso and virtio-win vfd as d/s does and as oVirt wants to do as well - BZ1108789.

(auto-population is broken now in oVirt even dirs/files are existing after manual preparation - BZ1113433).

http://www.ovirt.org/Features/oVirt_Windows_Guest_Tools

rpms are not present in http://resources.ovirt.org/pub/ovirt-3.5-pre/rpm/el6/

Comment 1 Itamar Heim 2014-06-29 10:36:11 UTC
seems like a missing step in implementing bug 1026930

Comment 2 Sandro Bonazzola 2014-07-24 09:52:52 UTC
Moving back to post, missing spec require change in ovirt-engine.

Comment 3 Sandro Bonazzola 2014-08-19 08:01:32 UTC
Thinking better on this, I think that we shouldn't require ovirt-guest-tools rpm as dependency of ovirt-engine.

The package is ~60Mb and it's not useful if you don't have windows VMs.

So I think we can move this to ON_QA as is.
The RPM is already available: 

http://resources.ovirt.org/pub/ovirt-3.5-pre/rpm/fc19/noarch/ovirt-guest-tools-3.5.0-0.5.master.noarch.rpm

We still need the code for automatically upload the iso to the ISO domain if available but that's a different issue not covered by this BZ.

Comment 4 Bob Doolittle 2014-08-19 12:30:19 UTC
What does downstream do?

Comment 5 Jiri Belka 2014-09-04 12:42:30 UTC
- 'iso' is missing from rpm name, d/s have 'iso' in the rpm name

# rpm -qlp http://10.34.63.204/repo-tlv-builds/ovirt-3.5-pre/rpm/el6/noarch/ovirt-guest-tools-3.5.0-0.5.master.noarch.rpm
/usr/share/ovirt-guest-tools
/usr/share/ovirt-guest-tools/ovirt-guest-tools-3.5_5.iso

- this BZ doesn't solve virtio-win, i tried my best with BZ1138291. please try to solve it (i'm little boss here, just QA, not pusher to get rpm). then please modify BZ title to state if this BZ should ignore virtio-win or not. thx!

Comment 6 Bob Doolittle 2014-12-01 16:07:30 UTC
The last comment for this bug says "this BZ doesn't solve virtio-win", but the synopsis of this bug and also bug 1026930 seem to indicate that virtio-win is in fact addressed. On the other hand we have bug 1138291 which has no description but seems to indicate an issue remains.

Can somebody please update the bug statuses to reflect the state of things more clearly?

Comment 7 Lev Veyde 2014-12-01 17:52:00 UTC
(In reply to Bob Doolittle from comment #6)
> The last comment for this bug says "this BZ doesn't solve virtio-win", but
> the synopsis of this bug and also bug 1026930 seem to indicate that
> virtio-win is in fact addressed. On the other hand we have bug 1138291 which
> has no description but seems to indicate an issue remains.
> 
> Can somebody please update the bug statuses to reflect the state of things
> more clearly?

The current status is that there is an ovirt-guest-tools-iso RPM available (which btw contains VirtIO-Win drivers on the ISO, however doesn't provide the VFDs).

We're still missing VirtIO-Win RPM, and this one is in progress (BZ#1138291).
Once that task is complete we'll get both the VirtIO-Win ISO and (what's more important) VFDs.

Comment 8 Bob Doolittle 2014-12-01 18:42:03 UTC
In that case please update the Synopsis of this bug so that it does not mislead people into thinking it solves an issue for a VirtIO-Win RPM.

Comment 9 Jiri Belka 2014-12-16 16:40:50 UTC
ok

# rpm -qlp http://resources.ovirt.org/pub/ovirt-3.5/rpm/el6Server/noarch/ovirt-guest-tools-iso-3.5-7.noarch.rpm
warning: http://resources.ovirt.org/pub/ovirt-3.5/rpm/el6Server/noarch/ovirt-guest-tools-iso-3.5-7.noarch.rpm: Header V4 RSA/SHA1 Signature, key ID fe590cb7: NOKEY
/usr/share/doc/ovirt-guest-tools-iso
/usr/share/doc/ovirt-guest-tools-iso/COPYING.csv
/usr/share/ovirt-guest-tools-iso
/usr/share/ovirt-guest-tools-iso/oVirt-toolsSetup_3.5_7.iso
/usr/share/ovirt-guest-tools-iso/ovirt-tools-setup.iso

Comment 10 Sandro Bonazzola 2015-01-21 16:04:25 UTC
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.